Skip to content

Fix module-only vPack build feed credentials - #28356

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
masterfrom
fix/vpack-module-feed-credentials
Nov 5, 2026
Merged

Dongbo Wang (daxian-dbw) merged 1 commit into
masterfrom
fix/vpack-module-feed-credentials

Conversation

@adityapatwardhan

Copy link
Copy Markdown
Member

PR Summary

Export VSS_NUGET_EXTERNAL_FEED_ENDPOINTS explicitly in the vPack and MSIX PowerShell build steps, including when UseEarlyAccessModules is enabled without IsEarlyAccess.

Use the same direct environment mapping as the other build templates. Keep the credential-producing variable secret and preserve the existing .NET runtime-feed-key conditions.

Add regression coverage for both build-step environment mappings and document the explicit secret-mapping requirement.

PR Context

Follow-up to #28326. Azure Pipelines does not automatically export secret variables to subsequent processes. Gating these mappings only on IsEarlyAccess leaves module-only builds without credentials for noninteractive module restores.

This fixes master first. After merge, backport the fix to release/v7.6.10, where #28355 carries the original module-feed feature.

Validation:

  • Parsed both pipeline YAML files and verified direct credential mapping for all four early-access flag combinations.
  • Confirmed existing runtime-key behavior and secret publication are unchanged.
  • Executed the new regression-test regexes against the fixed files and original master: both fixes pass and both original files fail.
  • PowerShell syntax parsing and git diff --check passed.
  • The full Pester file could not run: Pester is unavailable locally and PowerShell Gallery hosts could not be resolved. Pipeline authentication requires Azure Pipelines validation.

PR Checklist

Map secret feed credentials directly into the vPack and MSIX build environments, matching other build templates.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added Issue-Bug Issue has been identified as a bug in the product WG-Maintainers-Build specific to affecting the build CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Nov 5, 2026
Copilot AI balanced review requested due to automatic review settings November 5, 2026 18:36
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues with the feed credential-mapping changes.

No open issues 🎉

What changed in this PR

Fixes feed authentication for vPack and MSIX builds that enable early-access modules without enabling early-access .NET, completing the internal module-feed support added in #28326.

Changes:

  • Maps secret feed credentials directly into both build-step environments while preserving existing runtime-feed-key conditions.
  • Adds regression checks for both environment mappings.
  • Documents Azure Pipelines’ explicit secret-mapping requirement.
File Description
test/​infrastructure/​NugetConfig.Tests.ps1 Adds regression checks for direct credential mappings in both pipelines.
docs/​building/​internals.md Explains explicit secret mapping, including module-only builds.
.pipelines/​templates/​stages/​PowerShell-vPack-Stages.yml Removes the early-access condition from the vPack credential mapping.
.pipelines/​MSIXBundle-vPack-Official.yml Makes the MSIX credential mapping unconditional while retaining the runtime-key condition.

Review effort: Balanced

@daxian-dbw Dongbo Wang (daxian-dbw) removed Issue-Bug Issue has been identified as a bug in the product WG-Maintainers-Build specific to affecting the build labels Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.6.x-Done Backport-7.7.x-Migrated CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants