Repository navigation
Fix module-only vPack build feed credentials - #28356
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoNov 5, 2026
Merged
Conversation
Map secret feed credentials directly into the vPack and MSIX build environments, matching other build templates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Aditya Patwardhan (adityapatwardhan)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
November 5, 2026 18:36
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
3 of 9 tasks
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues with the feed credential-mapping changes.
No open issues 🎉
What changed in this PR
Fixes feed authentication for vPack and MSIX builds that enable early-access modules without enabling early-access .NET, completing the internal module-feed support added in #28326.
Changes:
- Maps secret feed credentials directly into both build-step environments while preserving existing runtime-feed-key conditions.
- Adds regression checks for both environment mappings.
- Documents Azure Pipelines’ explicit secret-mapping requirement.
| File | Description |
|---|---|
test/infrastructure/NugetConfig.Tests.ps1 |
Adds regression checks for direct credential mappings in both pipelines. |
docs/building/internals.md |
Explains explicit secret mapping, including module-only builds. |
.pipelines/templates/stages/PowerShell-vPack-Stages.yml |
Removes the early-access condition from the vPack credential mapping. |
.pipelines/MSIXBundle-vPack-Official.yml |
Makes the MSIX credential mapping unconditional while retaining the runtime-key condition. |
Review effort: Balanced
Dongbo Wang (daxian-dbw)
approved these changes
Nov 5, 2026
Dongbo Wang (daxian-dbw)
deleted the
fix/vpack-module-feed-credentials
branch
November 5, 2026 18:48
3 of 9 tasks
3 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Export
VSS_NUGET_EXTERNAL_FEED_ENDPOINTSexplicitly in the vPack and MSIX PowerShell build steps, including whenUseEarlyAccessModulesis enabled withoutIsEarlyAccess.Use the same direct environment mapping as the other build templates. Keep the credential-producing variable secret and preserve the existing .NET runtime-feed-key conditions.
Add regression coverage for both build-step environment mappings and document the explicit secret-mapping requirement.
PR Context
Follow-up to #28326. Azure Pipelines does not automatically export secret variables to subsequent processes. Gating these mappings only on
IsEarlyAccessleaves module-only builds without credentials for noninteractive module restores.This fixes master first. After merge, backport the fix to
release/v7.6.10, where #28355 carries the original module-feed feature.Validation:
git diff --checkpassed.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header