Repository navigation
[release/v7.7.0] Fix the resource string WeakCatalogHashAlgorithm - #28350
Closed
Justin Chung (jshigetomi) wants to merge 2 commits into
Closed
Justin Chung (jshigetomi) wants to merge 2 commits into
Justin Chung (jshigetomi) wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the backport correcting the SHA-1 warning wording for version 1 file catalogs.
No open issues 🎉
What changed in this PR
Backports the WeakCatalogHashAlgorithm wording correction to release/v7.7.0. The current diff also includes the prerequisite SHA-1 warning changes from #28342.
Changes:
- Adds warnings when generating or validating version 1 file catalogs.
- Identifies SHA-1 accurately in the warning and recommends regenerating catalogs with
-CatalogVersion 2.
| File | Description |
|---|---|
| src/System.Management.Automation/security/CatalogHelper.cs | Adds legacy catalog warnings to generation and validation. |
| src/System.Management.Automation/resources/CatalogStrings.resx | Adds the corrected SHA-1 warning text and localization constraints. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28322 to
release/v7.7.0.Depends on #28342. This branch includes that prerequisite commit so the diff will narrow automatically after it merges.