Repository navigation
[release/v7.7.0] Localized file check-in: Build ID 2785816 - #28347
Closed
Justin Chung (jshigetomi) wants to merge 2 commits into
Closed
Justin Chung (jshigetomi) wants to merge 2 commits into
Justin Chung (jshigetomi) wants to merge 2 commits into
Conversation
(cherry picked from commit 097b42e)
…0: Build ID 2785816 (PowerShell#28288) (cherry picked from commit 2725d6a)
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The version 1 catalog warning incorrectly names SHA0 instead of SHA-1 and omits the version number, with the same stale wording in all 13 culture-specific resource files.
1 open issue
What changed in this PR
Backports localization build 2785816 from #28288 to release/v7.7.0, adding resource entries for PowerShell’s legacy File Catalog warning. The current diff also includes the prerequisite warning implementation from #28342.
Changes:
- Emits a warning when generating or validating version 1 catalogs.
- Adds the neutral warning text and matching entries in 13 culture-specific resource files.
- Recommends regenerating legacy catalogs with
-CatalogVersion 2.
| File | Description |
|---|---|
src/System.Management.Automation/security/CatalogHelper.cs |
Adds warning calls during catalog generation and validation. |
src/System.Management.Automation/resources/zh-Hant/CatalogStrings.zh-Hant.resx |
Adds the Traditional Chinese resource entry. |
src/System.Management.Automation/resources/zh-Hans/CatalogStrings.zh-Hans.resx |
Adds the Simplified Chinese resource entry. |
src/System.Management.Automation/resources/tr/CatalogStrings.tr.resx |
Adds the Turkish resource entry. |
src/System.Management.Automation/resources/ru/CatalogStrings.ru.resx |
Adds the Russian resource entry. |
src/System.Management.Automation/resources/pt-BR/CatalogStrings.pt-BR.resx |
Adds the Brazilian Portuguese resource entry. |
src/System.Management.Automation/resources/pl/CatalogStrings.pl.resx |
Adds the Polish resource entry. |
src/System.Management.Automation/resources/ko/CatalogStrings.ko.resx |
Adds the Korean resource entry. |
src/System.Management.Automation/resources/ja/CatalogStrings.ja.resx |
Adds the Japanese resource entry. |
src/System.Management.Automation/resources/it/CatalogStrings.it.resx |
Adds the Italian resource entry. |
src/System.Management.Automation/resources/fr/CatalogStrings.fr.resx |
Adds the French resource entry. |
src/System.Management.Automation/resources/es/CatalogStrings.es.resx |
Adds the Spanish resource entry. |
src/System.Management.Automation/resources/de/CatalogStrings.de.resx |
Adds the German resource entry. |
src/System.Management.Automation/resources/cs/CatalogStrings.cs.resx |
Adds the Czech resource entry. |
src/System.Management.Automation/resources/CatalogStrings.resx |
Defines the neutral legacy-catalog warning text. |
Review effort: Balanced
| <value>Catalog version is not valid. We only support catalog version {0} and version {1}.</value> | ||
| </data> | ||
| <data name="WeakCatalogHashAlgorithm" xml:space="preserve"> | ||
| <value>'{0}' is a version catalog that uses SHA0 or SHA1. Consider regenerating this catalog with '-CatalogVersion 2'.</value> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28288 to
release/v7.7.0.Depends on #28342. This branch includes that prerequisite commit so the diff will narrow automatically after it merges.