Repository navigation
[release/v7.7.0] Add warning for SHA-1 File Catalog - #28342
Closed
Justin Chung (jshigetomi) wants to merge 1 commit into
Closed
Justin Chung (jshigetomi) wants to merge 1 commit into
Justin Chung (jshigetomi) wants to merge 1 commit into
Conversation
(cherry picked from commit 097b42e)
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Nov 5, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The security warning is misleading because it omits catalog version 1 and incorrectly names SHA0 instead of SHA-1.
1 open issue
What changed in this PR
Backports #27805 to release/v7.7.0, adding an advisory warning when PowerShell creates or validates legacy SHA-1 file catalogs.
Changes:
- Adds a shared warning helper used during catalog generation and validation.
- Adds warning text recommending regeneration with
-CatalogVersion 2.
| File | Description |
|---|---|
src/System.Management.Automation/security/CatalogHelper.cs |
Emits warnings when generating or validating version 1 catalogs. |
src/System.Management.Automation/resources/CatalogStrings.resx |
Adds the legacy catalog warning resource. |
Review effort: Balanced
| <value>Catalog version is not valid. We only support catalog version {0} and version {1}.</value> | ||
| </data> | ||
| <data name="WeakCatalogHashAlgorithm" xml:space="preserve"> | ||
| <value>'{0}' is a version catalog that uses SHA0 or SHA1. Consider regenerating this catalog with '-CatalogVersion 2'.</value> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27805 to
release/v7.7.0.