Skip to content

[release/v7.6.10] Fix the resource string WeakCatalogHashAlgorithm - #28334

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:release/v7.6.10from
daxian-dbw:backport/release/v7.6.10/28322-3209d2a64
Nov 4, 2026
Merged

Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:release/v7.6.10from
daxian-dbw:backport/release/v7.6.10/28322-3209d2a64

Conversation

@daxian-dbw

Copy link
Copy Markdown
Member

Backport of #28322 to release/v7.6.10

Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw)

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Customer Impact

  • Customer reported
  • Found internally

Corrects the WeakCatalogHashAlgorithm warning to accurately identify version 1 catalogs and the weak SHA-1 hash algorithm, removing the incorrect SHA0 reference. Adds localization guidance preserving SHA-1 and -CatalogVersion 2 in translations.

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

Corrects inaccurate warning wording introduced by #27805, already backported via #28311.

Testing

Reviewed backport commit 06453ac: the resource text and localization comment match the original PR diff. Cherry-pick completed without conflicts and the working tree is clean. Local tests were not run; backport CI must pass before merge.

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

Changes only resource text and a localization comment; no executable code or catalog validation behavior changes.

@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 4, 2026
Copilot AI balanced review requested due to automatic review settings November 4, 2026 18:16
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for this catalog warning text correction.

No open issues 🎉

What changed in this PR

Backports #28322 to release/v7.6.10, correcting the catalog warning text without changing executable code or catalog validation behavior.

Changes:

  • Identifies version 1 catalogs as using the weak SHA-1 algorithm, removing the incorrect SHA0 reference.
  • Adds localization guidance to preserve SHA-1 and -CatalogVersion 2.
File Description
src/​System.Management.Automation/​resources/​CatalogStrings.resx Corrects WeakCatalogHashAlgorithm wording and adds localization guidance.

Review effort: Balanced

@jshigetomi Justin Chung (jshigetomi) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this backport is diff-equivalent to merged and approved PR #28322. The corrected resource text and localization guidance are preserved; no unrelated changes.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 9520362 into PowerShell:release/v7.6.10 Nov 4, 2026
45 of 47 checks passed
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the backport/release/v7.6.10/28322-3209d2a64 branch November 4, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants