Skip to content

Clear output encodings before the ShellExecute fallback for native commands #28327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wei-Lun Li (b84330808) wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clear output encodings before the ShellExecute fallback for native commands #28327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/System.Management.Automation/engine/NativeCommandProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,11 @@ private void InitNativeProcess()
startInfo.RedirectStandardInput = false;
startInfo.RedirectStandardOutput = false;
startInfo.RedirectStandardError = false;

// The encodings are only allowed when the matching stream is redirected, so clear them too.
// Otherwise 'Process.Start' throws an 'InvalidOperationException' before ShellExecute is tried.
startInfo.StandardOutputEncoding = null;
startInfo.StandardErrorEncoding = null;
_nativeProcess.Start();
}
else
Expand Down
22 changes: 22 additions & 0 deletions test/powershell/Language/Scripting/NativeExecution/NativeCommandProcessor.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,28 @@ Describe "Native Command Processor" -tags "Feature" {
Get-Content $TestDrive/stdout.txt | Should -Be testing
Get-Content $TestDrive/stderr.txt | Should -Be gnitset
}

It 'Reports the real start error when <Script> fails to start' -Skip:(!$IsWindows) -TestCases @(
@{ Script = '$null = & $args[0]' }
@{ Script = '& $args[0] 2>$null' }
) {
param($Script)

# Not a valid executable, so 'CreateProcess' fails and the ShellExecute fallback is used.
$notAnExe = Join-Path $TestDrive 'notAnExe.exe'
Set-Content -Path $notAnExe -Value 'not an executable'

$ps = [powershell]::Create()
try {
$null = $ps.AddScript($Script).AddArgument($notAnExe).AddCommand('Out-Default').Invoke()
$ps.Streams.Error.Count | Should -Be 1
$ps.Streams.Error[0].FullyQualifiedErrorId | Should -BeExactly 'NativeCommandFailed'
$ps.Streams.Error[0].Exception.InnerException | Should -BeOfType System.ComponentModel.Win32Exception
}
finally {
$ps.Dispose()
}
}
}

Describe "Open a text file with NativeCommandProcessor" -tags @("Feature", "RequireAdminOnWindows") {
Expand Down