Repository navigation
Clear output encodings before the ShellExecute fallback for native commands - #28327
Open
Wei-Lun Li (b84330808) wants to merge 1 commit into
Open
Wei-Lun Li (b84330808) wants to merge 1 commit into
Wei-Lun Li (b84330808) wants to merge 1 commit into
Conversation
…mmands When a native command whose stdout or stderr is captured fails to start, the ShellExecute fallback turns off the stream redirection but keeps `StandardOutputEncoding` and `StandardErrorEncoding`. `Process.Start` then throws "StandardOutputEncoding is only supported when standard output is redirected", so ShellExecute is never tried and the real start error is lost. Clear both encodings together with the redirection flags. Fixes PowerShell#28225
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the change to preserve native-command launch errors during the Windows ShellExecute fallback.
No open issues 🎉
What changed in this PR
Fixes #28225 by clearing output encodings before Windows retries a native command with ShellExecute, preventing an encoding validation error from masking the launch failure.
Changes:
- Clear standard output and error encodings when disabling redirection for the fallback.
- Add Windows-only regression tests for captured stdout and redirected stderr, checking that failures expose a
Win32Exception.
| File | Description |
|---|---|
test/powershell/Language/Scripting/NativeExecution/NativeCommandProcessor.Tests.ps1 |
Tests launch-error reporting for both redirection scenarios. |
src/System.Management.Automation/engine/NativeCommandProcessor.cs |
Clears output encodings before the ShellExecute retry. |
Review effort: Balanced
microsoft-github-policy-service
Bot
added
the
Review - Needed
Contributor
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #28225.
When a native command fails to start on Windows and it is the only command in the pipeline, PowerShell retries with ShellExecute. That retry turns off the stream redirection but leaves
StandardOutputEncoding/StandardErrorEncodingset, soProcess.Startthrows before ShellExecute is tried:This change clears both encodings together with the redirection flags. With it, both forms report the real start error, the same as
& .\notpe.exe | Out-Null.PR Context
The encodings were added for redirected native output, but the ShellExecute fallback was not updated to clear them, so any captured native command that needs the fallback fails with an unrelated
InvalidOperationExceptioninstead.The new test (Windows only) runs a non-PE
.exewith stdout captured and with stderr redirected, and checks that the error's inner exception is theWin32Exceptionfrom starting the process. It fails without the fix.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header