Repository navigation
Fix the resource string WeakCatalogHashAlgorithm - #28322
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoNov 4, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Dongbo Wang (daxian-dbw)
added
the
CL-BuildPackaging
3 of 9 tasks
Dongbo Wang (daxian-dbw)
added
Backport-7.7.x-Consider
and removed
Backport-7.4.x-Consider
Backport-7.5.x-Consider
labels
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the catalog-warning wording and localization metadata changes.
No open issues 🎉
What changed in this PR
This follow-up to #27805 corrects PowerShell’s weak file-catalog hash warning to accurately describe version 1 catalogs.
Changes:
- Replaces the incorrect SHA0/SHA1 wording with “version 1” and “weak SHA-1 hash algorithm.”
- Adds localization metadata to preserve
SHA-1and-CatalogVersion 2.
| File | Description |
|---|---|
src/System.Management.Automation/resources/CatalogStrings.resx |
Corrects the warning text and adds localization constraints. |
Review effort: Balanced
12 tasks
Justin Chung (jshigetomi)
approved these changes
Nov 4, 2026
Justin Chung (jshigetomi)
left a comment
Justin Chung (jshigetomi)
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed; no blocking issues found.
Aditya Patwardhan (adityapatwardhan)
approved these changes
Nov 4, 2026
Dongbo Wang (daxian-dbw)
merged commit Nov 4, 2026
3209d2a
into
PowerShell:master
42 of 43 checks passed
Dongbo Wang (daxian-dbw)
added
Backport-7.6.x-Approved
and removed
Backport-7.6.x-Consider
labels
3 of 9 tasks
Dongbo Wang (daxian-dbw)
added
Backport-7.7.x-Approved
and removed
Backport-7.7.x-Consider
labels
3 of 9 tasks
Justin Chung (jshigetomi)
added
Backport-7.7.x-Migrated
and removed
Backport-7.7.x-Approved
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a follow-up change of the PR #27805.
The resource string for
WeakCatalogHashAlgorithmneeds to be updated to be accurate -- theGetCatalogHashAlgorithmthrows a terminating error when the passed-incatalogVersionis neither 1 nor 2, so mentioningSHA0is incorrect.