Repository navigation
Specify version 1 catalog in warning for weak catalog version - #28321
Closed
Anam Navied (anamnavi) wants to merge 1 commit into
Closed
Anam Navied (anamnavi) wants to merge 1 commit into
Anam Navied (anamnavi) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Anam Navied (anamnavi)
added
CL-General
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the catalog hash warning clarification.
No open issues 🎉
What changed in this PR
Clarifies PowerShell’s warning for weak catalog hashes without changing catalog behavior.
Changes:
- Updates
WeakCatalogHashAlgorithmto identify version 1 catalogs as using SHA1. - Retains the recommendation to regenerate the catalog with
-CatalogVersion 2.
| File | Description |
|---|---|
src/System.Management.Automation/resources/CatalogStrings.resx |
Clarifies the catalog version and hash algorithm in the warning message. |
Review effort: Balanced
Member
|
I will close this one and use #28322 for the fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request makes a minor update to the
CatalogStrings.resxresource file to clarify the warning message about weak catalog hash algorithms.WeakCatalogHashAlgorithmmessage to specify that only version 1 catalogs use SHA1, improving the accuracy and clarity of the warning.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header