Skip to content

Bind Hyper-V socket server V2 to the selected partition VM ID #28204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Justin Chung (jshigetomi) merged 2 commits into from
Oct 19, 2026
Merged

Bind Hyper-V socket server V2 to the selected partition VM ID #28204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a36af32
Remove Wildcard GUID in HyperVSocketServer V2 Constructor (#165)
Oct 6, 2026
3cb8654
Merge branch 'master' into 116136
jshigetomi Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions src/System.Management.Automation/engine/remoting/common/RemoteSessionHyperVSocket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,25 @@ internal sealed class RemoteSessionHyperVSocketServer : IDisposable

#endregion

#region Helpers

/// <summary>
/// Gets the partition-specific Hyper-V VM ID that the session server listens on.
/// </summary>
/// <param name="loopbackMode">
/// When <see langword="true"/>, communication stays within the same partition
/// (HV_GUID_LOOPBACK); otherwise it targets the parent/host partition (HV_GUID_PARENT).
/// </param>
/// <returns>The VM ID used to bind the listening socket.</returns>
internal static Guid GetListenerVmId(bool loopbackMode)
{
Guid loopbackId = new Guid("e0e16197-dd56-4a10-9195-5ee7a155a838"); // HV_GUID_LOOPBACK
Guid parentId = new Guid("a42e7cda-d03f-480c-9cc2-a4de20abb878"); // HV_GUID_PARENT
return loopbackMode ? loopbackId : parentId;
}

#endregion

#region Constructors

public RemoteSessionHyperVSocketServer(bool LoopbackMode)
Expand All @@ -188,9 +207,7 @@ public RemoteSessionHyperVSocketServer(bool LoopbackMode)
try
{
Guid serviceId = new Guid("a5201c21-2770-4c11-a68e-f182edb29220"); // HV_GUID_VM_SESSION_SERVICE_ID_2
Guid loopbackId = new Guid("e0e16197-dd56-4a10-9195-5ee7a155a838"); // HV_GUID_LOOPBACK
Guid parentId = new Guid("a42e7cda-d03f-480c-9cc2-a4de20abb878"); // HV_GUID_PARENT
Guid vmId = LoopbackMode ? loopbackId : parentId;
Guid vmId = GetListenerVmId(LoopbackMode);
HyperVSocketEndPoint endpoint = new HyperVSocketEndPoint(HyperVSocketEndPoint.AF_HYPERV, vmId, serviceId);

Socket listenSocket = new Socket(endpoint.AddressFamily, SocketType.Stream, (System.Net.Sockets.ProtocolType)1);
Expand Down Expand Up @@ -250,7 +267,11 @@ public RemoteSessionHyperVSocketServer(bool LoopbackMode, string token, DateTime
try
{
Guid serviceId = new Guid("a5201c21-2770-4c11-a68e-f182edb29220"); // HV_GUID_VM_SESSION_SERVICE_ID_2
HyperVSocketEndPoint endpoint = new HyperVSocketEndPoint(HyperVSocketEndPoint.AF_HYPERV, Guid.Empty, serviceId);

// Bind to a partition-specific VM ID (host parent, or local loopback), consistent
// with the V1 server constructor above.
Guid vmId = GetListenerVmId(LoopbackMode);
HyperVSocketEndPoint endpoint = new HyperVSocketEndPoint(HyperVSocketEndPoint.AF_HYPERV, vmId, serviceId);

Socket listenSocket = new Socket(endpoint.AddressFamily, SocketType.Stream, (System.Net.Sockets.ProtocolType)1);
listenSocket.Bind(endpoint);
Expand Down
12 changes: 12 additions & 0 deletions test/xUnit/csharp/test_RemoteHyperV.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,5 +802,17 @@ public async Task ValidateFailsWhenTokensMismatch(string token, string expectedT

await serverTask;
}

[SkippableTheory]
[InlineData(false, "a42e7cda-d03f-480c-9cc2-a4de20abb878")] // HV_GUID_PARENT (host partition)
[InlineData(true, "e0e16197-dd56-4a10-9195-5ee7a155a838")] // HV_GUID_LOOPBACK (same partition)
public void ServerListenerUsesExpectedPartitionVmId(bool loopbackMode, string expectedVmId)
{
// The session server must listen on a specific partition (host parent, or local
// loopback) depending on the requested mode.
Guid vmId = System.Management.Automation.Remoting.RemoteSessionHyperVSocketServer.GetListenerVmId(loopbackMode);

Assert.Equal(new Guid(expectedVmId), vmId);
}
}
}
Loading