Repository navigation
[release/v7.6.7] Revert "[release/v7.6.7] Simplify Microsoft Store listing metadata" - #28094
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoSep 24, 2026
Conversation
Dongbo Wang (daxian-dbw)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
September 24, 2026 20:58
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Dongbo Wang (daxian-dbw)
added
the
CL-BuildPackaging
Dongbo Wang (daxian-dbw)
merged commit Sep 24, 2026
7fdca76
into
release/v7.6.7
35 of 36 checks passed
Dongbo Wang (daxian-dbw)
deleted the
revert-28079-backport/release/v7.6.7/27968-8e1675f17
branch
September 24, 2026 21:00
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The submitted diff appears to reapply the simplification and contains a critical release-pipeline issue.
Review effort: Lite
Findings: 1
What changed in this PR
This PR intends to revert the Microsoft Store metadata simplification for release/v7.6.7. The submitted diff appears to reapply that simplification instead.
Changes:
- Modifies localized AppX resources and Store metadata.
- Changes release-note substitution and StoreBroker configuration.
- Adds channel-specific PDP and media handling.
Review finding: The release pipeline still uses the simplified en-us update rather than restoring localized listing behavior.
| File | Summary |
|---|---|
assets/AppxManifest.xml |
Changes localized resource declarations. |
.pipelines/templates/release-MSIX-Publish.yml |
Simplifies listing updates to en-us. |
.pipelines/templates/package-store-package.yml |
Changes PDP and packaging behavior. |
.pipelines/store/SBConfig.json |
Changes Store media configuration. |
.pipelines/store/PDP/PDP/en-US/PDP.xml |
Changes Store metadata structure and placeholders. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| if ($listingProperties.Count -eq 0) { | ||
| throw "Store listings are missing from '$jsonPath'." | ||
| } | ||
| $json.listings.'en-us'.baseListing.releaseNotes = $message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #28079
The order of backporting is wrong. Need to revert this one and backport it again after its prerequisites are backported.