Improve pointer lifecycle handling in PdhHelper - #28008
Merged
Patrick Meinecke (SeeminglyScience) merged 3 commits intoSep 11, 2026
Merged
Patrick Meinecke (SeeminglyScience) merged 3 commits into
Patrick Meinecke (SeeminglyScience) merged 3 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
This pull request improves unmanaged pointer lifecycle handling in PdhHelper during buffer reallocation.
Changes:
- Resets the freed pointer to
IntPtr.Zerobefore reallocation. - Prevents stale-pointer cleanup if allocation fails.
File summaries
| File | Description |
|---|---|
src/Microsoft.PowerShell.Commands.Diagnostics/PdhHelper.cs |
Safeguards pointer cleanup during PDH_MORE_DATA handling. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Travis Plunk (TravisEz13)
added
the
CL-General
Patrick Meinecke (SeeminglyScience)
approved these changes
Sep 11, 2026
Patrick Meinecke (SeeminglyScience)
left a comment
Patrick Meinecke (SeeminglyScience)
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 28008 in repo PowerShell/PowerShell |
Patrick Meinecke (SeeminglyScience)
merged commit Sep 11, 2026
5e35e5a
into
PowerShell:master
44 of 46 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request improves pointer handling in the LookupPerfNameByIndex method in PdhHelper.cs. When additional buffer space is required, the existing allocation is freed before a new allocation is created. This change explicitly resets the pointer to IntPtr.Zero after the free operation, ensuring the pointer state remains accurate throughout the reallocation flow.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header