Simplify Microsoft Store listing metadata - #27968
Justin Chung (jshigetomi) merged 6 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Justin Chung (jshigetomi)
added
the
CL-BuildPackaging
|
A related PR: #27966 -- it adds PDP.xml to the Loc Pipeline for localization. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 15d5aa39-2adb-4337-80ba-a1a8568d8fba
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟡 Changes recommended
The new “missing listings” validation can still throw an unhelpful null-valued expression error and should be tightened to reliably produce the intended failure message.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR simplifies Microsoft Store listing metadata handling in the release pipeline by making the PDP the static source of localized listing text and restricting release-time edits to placeholder substitution for version-specific values.
Changes:
- Replace per-release listing text rewrites with placeholder substitution (
___VERSION___,___CHANGELOGLINK___) across all Store listings during publish. - Remove channel-specific
AppStoreNamemutation and drop theAppStoreNameelement from the PDP. - Remove the dedicated
PDP-Mediatree / media config and reuse the PDP root as thepdpMediaPathinput required by StoreBroker v3.
File summaries
| File | Description |
|---|---|
| .pipelines/templates/release-MSIX-Publish.yml | Updates StoreBroker JSON handling to substitute version/changelog placeholders in release notes across all listing languages. |
| .pipelines/templates/package-store-package.yml | Removes PDP AppStoreName mutation and points StoreBroker v3 media-root input at the PDP root. |
| .pipelines/store/SBConfig.json | Removes media-related config properties that are no longer used with the simplified PDP/media setup. |
| .pipelines/store/PDPs/PDP/en-US/PDP.xml | Removes AppStoreName and defines release notes text using placeholders for publish-time substitution. |
| .pipelines/store/PDPs/PDP-Media/en-US/.gitkeep | Removes the now-unneeded PDP media tree placeholder file. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
Please update |
|
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 15d5aa39-2adb-4337-80ba-a1a8568d8fba
8e1675f
into
PowerShell:master
PR Summary
The Store release pipeline currently keeps an empty PDP media tree and rewrites localized listing text at release time. This change makes the PDP the static source of Store listing language while limiting release-time changes to version-specific values.
PDP-Mediatree.___VERSION___and___CHANGELOGLINK___, then replaces only those placeholders during publishing.AppStoreNameand its channel-specific mutation because the MSIX manifest already provides anen-USDisplayName.PR Context
Keeping localized release-note language in the PDP makes the listing easier to review and avoids modifying the description during release publishing. Removing
AppStoreNamealso avoids a Store submission conflict for a language whose display name is already supplied by the package manifest.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header