Add PDP.xml to the LocProject.json file - #27966
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoSep 4, 2026
Merged
Conversation
Dongbo Wang (daxian-dbw)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
September 3, 2026 17:33
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Dongbo Wang (daxian-dbw)
added
the
CL-BuildPackaging
Copilot started reviewing on behalf of
Dongbo Wang (daxian-dbw)
September 3, 2026 17:34
View session
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The newly added PDP.xml contains customer-facing text issues and many empty localizable placeholders that should be corrected/trimmed before localization and Store packaging.
Pull request overview
Adds Store listing PDP content to the localization project and updates pipeline paths to reflect the renamed PDP directory, enabling localization of MSIX Store-front strings.
Changes:
- Added
.pipelines/store/PDPs/PDP/en-US/PDP.xmlas aLocIteminLocalize/LocProject.jsonwithCopyOption: LangIDOnPath. - Updated Store packaging pipeline template paths to use
.pipelines/store/PDPs/...(includingPDP.xmlandPDP-Media). - Introduced the new PDP folder structure under
.pipelines/store/PDPs/(including a placeholderPDP-Medialanguage directory).
File summaries
| File | Description |
|---|---|
| Localize/LocProject.json | Adds PDP.xml as a localized input and configures language-folder output copying. |
| .pipelines/templates/package-store-package.yml | Updates Store packaging steps to reference the renamed PDPs directory for PDP and media inputs. |
| .pipelines/store/PDPs/PDP/en-US/PDP.xml | Adds the en-US PDP definition that will be localized and packaged for Store submissions. |
| .pipelines/store/PDPs/PDP-Media/en-US/.gitkeep | Ensures the expected PDP media directory structure exists for Store packaging. |
Review details
- Files reviewed: 2/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
12 tasks
Justin Chung (jshigetomi)
approved these changes
Sep 4, 2026
Dongbo Wang (daxian-dbw)
merged commit Sep 4, 2026
b664c2e
into
PowerShell:master
38 of 39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add PDP.xml to the
LocProject.jsonfile, so that we can localize the strings used in the MS Store front for the MSIX packages.store/PDPfolder tostore/PDPs..ymlfiles to use the updated path toPDP.xmlandPDP-Media.PDP.xmltoLocProject.jsonas aLocItem.LangIDOnPath-- Localized files are copied underOutputPathwith a language ID folder such as{OutputPath}\ko\B.resjsonfor ko (Korean), so that the folder structure will be as the follows:PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header