-
Notifications
You must be signed in to change notification settings - Fork 8.1k
modify Start-PSPester to accept -Quiet to eliminate Pester output #2795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify Start-PSPester to accept -Quiet to eliminate Pester output #2795
Conversation
|
|
|
With So how will failing tests be reported in a way we can easily see? I see our scripts will throw if there are any errors, but it just reports a count. If I'm missing the code that would report the errors to the console, can you point me to that code? |
|
The log file always contains the errors even if they're not emitted to the screen during the test run. I can add functionality to Test-PSPesterResults to emit the errors before throwing. This is probably the best we can hope for because there is so much output there is no way that Travis-CI will be able to run all of our tests. |
lzybkr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify Test-PSPesterResults so that it reports as much detail as possible about the test failures - this will make it easier for the maintainers to quickly see why builds are failing.
|
Do you wish to see the error details at all times? |
|
I can hardly imagine a scenario where I wouldn't want errors logged to the console, so yes, always. As for |
|
for the moment, I'm going to leave the verbose output for CI runs as I believe that the log output is useful. We can use the daily builds in travis-ci to determine whether we like it or no. |
|
Related PR #2600 from @SteveL-MSFT who open a feature request in Pester repo. |
also modify travis.ps1 to include -Quiet for Pester args to reduce stdout log size which should hopefully allow daily builds to run without being cancelled due to too much output
Test-PSPesterResults will now also emit information about the errors found during a test run rather than just the number of failed tests. Created a new errorlog function so the output of errors will be red.
6a3687a to
2441c89
Compare
also modify travis.ps1 to include -Quiet for Pester args to reduce
stdout log size which should hopefully allow daily builds to run
without being cancelled due to too much output