Update AppxManifest.xml to only declare en-US for the <Resources> element - #27939
Merged
Merged
Conversation
Dongbo Wang (daxian-dbw)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
September 1, 2026 16:00
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Dongbo Wang (daxian-dbw)
added
the
CL-BuildPackaging
Copilot started reviewing on behalf of
Dongbo Wang (daxian-dbw)
September 1, 2026 16:00
View session
Patrick Meinecke (SeeminglyScience)
approved these changes
Sep 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows AppX manifest to declare only en-US under <Resources>, aligning with the current state where MS Store-related strings are not localized.
Changes:
- Removed non-
en-US<Resource Language="..."/>entries fromassets/AppxManifest.xml. - Removed a CI compatibility note comment near the top of
build.psm1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build.psm1 | Removes a comment about CI PowerShell version compatibility near module initialization. |
| assets/AppxManifest.xml | Restricts declared AppX manifest resources to en-US only. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
9
to
11
| . "$PSScriptRoot\tools\buildCommon\startNativeExecution.ps1" | ||
|
|
||
| # CI runs with PowerShell 5.0, so don't use features like ?: && || | ||
| Set-StrictMode -Version 3.0 |
Member
Author
There was a problem hiding this comment.
It's likely a stale requirement. I have #27940 submitted to changes the shell to pwsh.
Dongbo Wang (daxian-dbw)
merged commit Sep 1, 2026
3eb14c4
into
PowerShell:master
43 of 44 checks passed
Dongbo Wang (daxian-dbw)
added
Backport-7.6.x-Approved
and removed
Backport-7.6.x-Consider
labels
Merged
9 tasks
Dongbo Wang (daxian-dbw)
added
Backport-7.6.x-Done
and removed
Backport-7.6.x-Approved
labels
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
We do not have the MS Store related text localized yet, so change the
<Resources>element back toen-USonly.