Skip to content

[release/v7.6.6] Fix install dotnet for non early access release - #27927

Merged
Aditya Patwardhan (adityapatwardhan) merged 1 commit into
PowerShell:release/v7.6.6from
adityapatwardhan:backport/release/v7.6.6/27892-9fa54b610
Sep 1, 2026
Merged

Aditya Patwardhan (adityapatwardhan) merged 1 commit into
PowerShell:release/v7.6.6from
adityapatwardhan:backport/release/v7.6.6/27892-9fa54b610

Conversation

@adityapatwardhan

Copy link
Copy Markdown
Member

Backport of #27892 to release/v7.6.6

Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Aditya Patwardhan (@adityapatwardhan)

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Corrects the release validation pipelines so non-early-access builds install .NET without forcing the early-access restore phase, while ensuring release version variables are initialized before package and global-tool validation.

Customer Impact

  • Customer reported
  • Found internally

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

This is not a regression.

Testing

Cherry-picked cleanly onto the latest upstream release/v7.6.6. Verified the worktree is clean, git diff --check passes, the commit changes only the two intended release-validation YAML templates, and .pipelines/templates/SetVersionVariables.yml exists on the target branch. The affected Azure Pipelines release-validation jobs require CI for end-to-end execution.

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

High risk because the change modifies shared release validation pipeline templates used for framework-dependent packages and global tools. The diff is narrowly scoped to version-variable initialization and conditional .NET installation parameters, and it matches the merged master change without conflict adaptations.

Copilot AI lite review requested due to automatic review settings September 1, 2026 01:37
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 1, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit e4a79f4 into PowerShell:release/v7.6.6 Sep 1, 2026
35 checks passed
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the backport/release/v7.6.6/27892-9fa54b610 branch September 1, 2026 01:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backports pipeline-template updates to release/v7.6.6 so the release validation jobs correctly initialize release version variables early and adjust how .NET is installed for early-access vs non-early-access runs.

Changes:

  • Adds SetVersionVariables.yml to both release validation templates to ensure version variables are available before later validation steps.
  • Updates the install-dotnet.yml invocation to make ob_restore_phase conditional (but the current condition appears inverted, changing non-early-access behavior).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.pipelines/templates/release-validate-globaltools.yml Initializes version variables earlier and modifies conditional parameters for install-dotnet.yml in global tool validation.
.pipelines/templates/release-validate-fxdpackages.yml Initializes version variables earlier and modifies conditional parameters for install-dotnet.yml in framework-dependent package validation.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 70 to +74
- template: /.pipelines/templates/install-dotnet.yml@self
parameters:
architecture: ${{ parameters.dotnetArch }}
ob_restore_phase: false
${{ if eq(parameters.IsEarlyAccess, true) }}:
ob_restore_phase: false
Comment on lines 84 to +88
- template: /.pipelines/templates/install-dotnet.yml@self
parameters:
architecture: ${{ parameters.dotnetArch }}
ob_restore_phase: false
${{ if eq(parameters.IsEarlyAccess, true) }}:
ob_restore_phase: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants