[release/v7.6.6] Fix comments in CmdletizationCoreResources.resx - #27924
Merged
Patrick Meinecke (SeeminglyScience) merged 1 commit intoSep 1, 2026
Conversation
Patrick Meinecke (SeeminglyScience)
added
the
CL-BuildPackaging
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Patrick Meinecke (SeeminglyScience)
September 1, 2026 01:21
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Backports a comment-only fix to the release/v7.6.6 branch to correct localization dev-rule comments in CmdletizationCoreResources.resx, removing {StrContains=...} directives that referenced substrings not present in the corresponding resource values (which can break localization pipeline validation).
Changes:
- Removed invalid
{StrContains="CmdletParameterMetadata"},{StrContains="PSName"}, and{StrContains="CmdletParameterSet"}dev-rule directives from affected resource comments. - Simplified the
EnumWriter_InvalidValueNamedev-rule directive to only require{StrContains="Name"}, matching the actual resource value content.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Aditya Patwardhan (adityapatwardhan)
approved these changes
Sep 1, 2026
Patrick Meinecke (SeeminglyScience)
merged commit Sep 1, 2026
a0460df
into
PowerShell:release/v7.6.6
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27879 to release/v7.6.6
Triggered by Patrick Meinecke (@SeeminglyScience) on behalf of Dongbo Wang (@daxian-dbw)
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Fixes localization dev-rule comments in CmdletizationCoreResources.resx that referenced string values missing from the resource, required for correct localization pipeline validation.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Cherry-picked cleanly with no conflicts. Comment-only fix, no functional testing required beyond standard CI.
Risk
REQUIRED: Check exactly one box.
Fixes developer-facing comments/dev-rules in a resx file; no impact on shipped resource values or runtime behavior.