[release/v7.5.11] Use Custom Validation Policy for vPack Pipeline - #27915
Merged
Justin Chung (jshigetomi) merged 1 commit intoSep 1, 2026
Merged
Justin Chung (jshigetomi) merged 1 commit into
Justin Chung (jshigetomi) merged 1 commit into
Conversation
Co-authored-by: Justin Chung <chungjustin@microsoft.com> Copilot-Session: 99e6a033-65fd-4a39-9a71-2ce9b7657c10 (cherry picked from commit bc487bf)
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Backport to release/v7.5.11 to unblock the vPack pipeline by disabling the injected CodeSign validation and instead validating the fully signed vPack payload against a repository-owned custom CodeSign policy.
Changes:
- Disables OneBranch-injected CodeSign validation for the vPack build job and adds an explicit CodeSign validation step using a custom policy file.
- Extends
obp-file-signing.ymlto support an overridable third-party signing profile and an option to sign all binaries through the “3rd party” flow. - Removes
globalSdl.useCustomPolicyfrom the vPack official pipeline and introduces the repo policy file at.config/codesignpolicy.xml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.pipelines/templates/stages/PowerShell-vPack-Stages.yml |
Disables injected validation, signs full payload, and runs custom-policy CodeSign validation for vPack. |
.pipelines/templates/obp-file-signing.yml |
Adds parameters to control third-party signing profile and optionally sign all binaries via that path. |
.pipelines/PowerShell-vPack-Official.yml |
Removes globalSdl.useCustomPolicy configuration from the official vPack pipeline. |
.config/codesignpolicy.xml |
Adds repository-owned “tools-only” CodeSign validation policy used by the pipeline. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
220
to
226
| parameters: | ||
| binPath: '$(Pipeline.Workspace)/Symbols_$(Architecture)' | ||
| SigningProfile: $(windows_build_tools_cert_id) | ||
| ThirdPartySigningProfile: $(windows_build_tools_cert_id) | ||
| SignAllBinariesWithThirdPartyProfile: true | ||
| OfficialBuild: false | ||
| vPackScenario: true |
Comment on lines
+111
to
+116
| $signAllBinaries = [System.Convert]::ToBoolean('${{ parameters.SignAllBinariesWithThirdPartyProfile }}') | ||
| if ($signAllBinaries) { | ||
| $missingSignatures = $signatures | Select-Object -ExpandProperty Path | ||
| } else { | ||
| $missingSignatures = $signatures | Where-Object { $_.status -eq 'notsigned' -or $_.SignerCertificate.Issuer -notmatch $testCert -or $_.SignerCertificate.Issuer -notmatch $officialIssuerPattern} | Select-Object -ExpandProperty Path | ||
| } |
Justin Chung (jshigetomi)
added
the
CL-BuildPackaging
Aditya Patwardhan (adityapatwardhan)
approved these changes
Sep 1, 2026
Justin Chung (jshigetomi)
merged commit Sep 1, 2026
03b54ee
into
PowerShell:release/v7.5.11
34 of 35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27911 to
release/v7.5.11.Signs the complete vPack payload with the Windows build tools certificate and validates it with the merged repository-owned tools-only CodeSign policy.