Fix install dotnet for non early access release - #27892
Merged
Merged
Conversation
Aditya Patwardhan (adityapatwardhan)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
August 27, 2026 06:11
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
August 27, 2026 06:12
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adjusts PowerShell release-validation pipeline templates to ensure version variables are initialized early and to only pass certain .NET installation parameters for early-access builds.
Changes:
- Adds
SetVersionVariables.ymlto both validation templates so release/version variables are established before subsequent steps. - Updates
install-dotnet.ymlinvocations to passob_restore_phase: falseonly whenIsEarlyAccessistrue.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.pipelines/templates/release-validate-globaltools.yml |
Initializes version variables earlier and gates install-dotnet’s ob_restore_phase parameter on early-access builds. |
.pipelines/templates/release-validate-fxdpackages.yml |
Initializes version variables earlier and gates install-dotnet’s ob_restore_phase parameter on early-access builds. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Dongbo Wang (daxian-dbw)
approved these changes
Aug 27, 2026
9 tasks
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request updates the pipeline templates for both
release-validate-fxdpackagesandrelease-validate-globaltoolsto improve version variable management and conditional parameter handling for .NET installation. The main changes focus on ensuring version variables are set early in the pipeline and that certain installation parameters are only applied during early access builds.Pipeline improvements:
SetVersionVariables.ymltemplate to bothrelease-validate-fxdpackages.ymlandrelease-validate-globaltools.ymlto ensure version variables are set before other steps run. [1] [2]install-dotnet.ymltemplate invocation in both pipelines to conditionally set theob_restore_phaseparameter only when the build is an early access build, improving clarity and correctness for early access scenarios. [1] [2]PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header