Skip to content

Improve output file path determination for Invoke-WebRequest #27872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Travis Plunk (TravisEz13) merged 1 commit into from
Aug 20, 2026
Merged

Improve output file path determination for Invoke-WebRequest #27872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...werShell.Commands.Utility/commands/utility/WebCmdlet/CoreCLR/WebResponseHelper.CoreClr.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ internal static string GetOutFilePath(HttpResponseMessage response, string quali
// Get file name from last segment of Uri
string? lastUriSegment = System.Net.WebUtility.UrlDecode(response.RequestMessage?.RequestUri?.Segments[^1]);

return Directory.Exists(qualifiedOutFile) ? Path.Join(qualifiedOutFile, lastUriSegment) : qualifiedOutFile;
return Directory.Exists(qualifiedOutFile)
? Path.Join(qualifiedOutFile, Path.GetFileName(lastUriSegment))
Comment thread
SeeminglyScience marked this conversation as resolved.
: qualifiedOutFile;
Comment thread
SeeminglyScience marked this conversation as resolved.
}

internal static string GetProtocol(HttpResponseMessage response) => string.Create(CultureInfo.InvariantCulture, $"HTTP/{response.Version}");
Expand Down
Loading