Improve output file path determination for Invoke-WebRequest - #27872
Merged
Travis Plunk (TravisEz13) merged 1 commit intoAug 20, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates how Invoke-WebRequest/web cmdlets derive an output file path when -OutFile points to a directory, by ensuring only a file name (not a decoded path) from the last URI segment is appended.
Changes:
- Update
WebResponseHelper.GetOutFilePathto wrap the decoded last URI segment withPath.GetFileNamebefore joining with the output directory.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Anam Navied (anamnavi)
added
the
CL-General
Patrick Meinecke (SeeminglyScience)
approved these changes
Aug 20, 2026
Travis Plunk (TravisEz13)
merged commit Aug 20, 2026
2fab4a6
into
PowerShell:master
36 of 42 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request refines output file path determination for Invoke-WebRequest when -OutFile references a directory.
The implementation now extracts the file name from the final URI segment before combining it with the destination directory, resulting in more consistent output file path generation.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header