Skip to content

[release/v7.6.5] Ship localized resources only for MSIX packages - #27799

Merged
Justin Chung (jshigetomi) merged 2 commits into
PowerShell:release/v7.6.5from
daxian-dbw:backport/release/v7.6.5/27725-b7cbb7a35
Aug 10, 2026
Merged

Justin Chung (jshigetomi) merged 2 commits into
PowerShell:release/v7.6.5from
daxian-dbw:backport/release/v7.6.5/27725-b7cbb7a35

Conversation

@daxian-dbw

Copy link
Copy Markdown
Member

Backport of #27725 to release/v7.6.5

Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw)

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Backports build/packaging changes that ship localized resources (satellite assemblies) only for MSIX packages, fix min-size build to use SelfContained deployment, and remove .xml files from packaging. Reduces package size by ~35mb.

Customer Impact

  • Customer reported
  • Found internally

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

This is not a regression.

Testing

Verified via binary build and package build pipelines in the original PR. Backport cherry-pick applied cleanly after conflict resolution in tools/packaging/packaging.psm1.

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

Changes to build and packaging scripts are well-scoped. The packaging logic changes are substantial but self-contained; the risk is medium due to the breadth of packaging.psm1 changes.

Merge Conflicts

tools/packaging/packaging.psm1 had conflicts due to divergence between master and release/v7.6.5; manually resolved.

Copilot AI lite review requested due to automatic review settings August 10, 2026 17:58
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from a team as a code owner August 10, 2026 17:58
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Aug 10, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backports build/packaging changes to reduce package size by limiting localized satellite assemblies to MSIX packages, adjusting min-size build deployment settings, and trimming unnecessary files from packaged outputs.

Changes:

  • Update Start-PSBuild to suppress satellite assembly generation for most builds unless explicitly forced, and mark min-size builds to skip ReadyToRun.
  • Update packaging flow to (a) remove .xml docs during signed-build folder preparation and (b) strip any remaining localized resource folders from ZIP packages for win-{x64,x86,arm64} builds.
  • Expand MSIX manifest resource language declarations to match the set of supported localizations.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tools/packaging/packaging.psm1 Packaging refactor: ZIP/MSIX behavior changes, resource-folder stripping logic, and signed build folder cleanup updates.
build.psm1 Build updates for localization production defaults and min-size build properties (SelfContained + no R2R).
PowerShell.Common.props MSBuild condition update to disable ReadyToRun when ForMinimalSize=True.
assets/AppxManifest.xml MSIX resource languages expanded beyond en-US.
.pipelines/templates/windows-hosted-build.yml Removes extra blank lines (format-only change).
Suppressed comments (1)

tools/packaging/packaging.psm1:2532

  • Typo in comment: "pacakge" should be "package".
            # The 'win-x64/x86/arm64' builds contain localized resources, but we ship localized resources for MSIX pacakge only.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread tools/packaging/packaging.psm1
Comment thread tools/packaging/packaging.psm1
Comment thread tools/packaging/packaging.psm1
Comment thread tools/packaging/packaging.psm1
@jshigetomi
Justin Chung (jshigetomi) enabled auto-merge (squash) August 10, 2026 18:14
@jshigetomi
Justin Chung (jshigetomi) merged commit 82f53ec into PowerShell:release/v7.6.5 Aug 10, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants