[release/v7.5.10] Fix the dot-sourcing behavior of pwsh -file for advanced-function scripts - #27761
Merged
Justin Chung (jshigetomi) merged 1 commit intoAug 5, 2026
Conversation
Patrick Meinecke (SeeminglyScience)
added
the
CL-Engine
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Patrick Meinecke (SeeminglyScience)
August 4, 2026 20:57
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Backports the upstream engine fix from #27727 to release/v7.5.10 to align pwsh -File dot-sourcing behavior between “simple scripts” and “advanced-function scripts” under WDAC/CLM scenarios.
Changes:
- Exposes whether the script cmdlet should rethrow
ExitExceptionvia a new internalPSScriptCmdletproperty. - Updates the advanced-script execution path (
CommandProcessor) to skipValidateCompatibleLanguageModefor non--NoExit-Fileexecution, matching the simple-script path behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs | Adds an internal accessor for the script cmdlet’s “rethrow exit” state used to match language-mode validation behavior. |
| src/System.Management.Automation/engine/CommandProcessor.cs | Aligns dotted script language-mode validation logic with the ScriptCommandProcessor behavior for pwsh -File (non--NoExit). |
Comment on lines
780
to
+783
| // If the script has been dotted, throw an error if it's from a different language mode. | ||
| if (!this.UseLocalScope) | ||
| // Unless it was a script loaded through -File, in which case the danger of dotting other | ||
| // language modes (getting internal functions in the user's state) isn't a danger. | ||
| if (!this.UseLocalScope && !scriptCmdlet.ShouldRethrowExitException) |
Justin Chung (jshigetomi)
approved these changes
Aug 4, 2026
Justin Chung (jshigetomi)
merged commit Aug 5, 2026
6475d29
into
PowerShell:release/v7.5.10
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27727 to release/v7.5.10
Triggered by Patrick Meinecke (@SeeminglyScience) on behalf of Dongbo Wang (@daxian-dbw)
Original CL Label: CL-Engine
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Customer Impact
Fixes inconsistent WDAC behavior where signed advanced-function scripts failed under pwsh -file while signed simple scripts succeeded. Aligns both code paths so non-noexit file execution behaves consistently.
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Validated by original PR scenario coverage for WDAC mode and pwsh -file advanced-function behavior; this backport is a direct cherry-pick with no conflict changes.
Risk
REQUIRED: Check exactly one box.
Engine behavior change is narrowly scoped to the language-mode compatibility check path for script invocation and keeps existing -noexit behavior intact.