Skip to content

Fix Test-Connection to correctly report BufferSize of 0 #27657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raman118 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Test-Connection to correctly report BufferSize of 0 #27657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Microsoft.PowerShell.Commands.Management/commands/management/TestConnectionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,9 +485,9 @@ private void ProcessTraceroute(string targetNameOrAddress)
? reply.RoundtripTime
: timer.ElapsedMilliseconds,

// If we use the empty buffer, then .NET actually uses a 32 byte buffer so we want to show
// as the result object the actual buffer size used instead of 0.
buffer.Length == 0 ? DefaultSendBufferSize : buffer.Length,
// If we use the empty buffer for default size, we want to show
// the requested BufferSize (32) instead of the actual buffer length (0).
Comment on lines +488 to +489
BufferSize,
pingNum: i);
WriteObject(new TraceStatus(
currentHop,
Expand Down Expand Up @@ -732,7 +732,7 @@ private void ProcessPing(string targetNameOrAddress)
resolvedTargetName,
reply,
reply.RoundtripTime,
buffer.Length == 0 ? DefaultSendBufferSize : buffer.Length,
BufferSize,
pingNum: (uint)i));
}

Expand Down
6 changes: 6 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,12 @@ Describe "Test-Connection" -tags "CI", "RequireSudoOnUnix" {
$result.BufferSize | Should -Be 2
}

It "BufferSize 0 works and returns 0" {
$result = Test-Connection $targetName -Count 1 -BufferSize 0

$result.BufferSize | Should -Be 0
}

It "ResolveDestination for address" {
$result = Test-Connection $targetAddress -ResolveDestination -Count 1
$resolvedName = [System.Net.DNS]::GetHostEntry($targetAddress).HostName
Expand Down