Skip to content

Initial Support for Fedora 24 - #2738

Merged
Mike Richmond (mirichmo) merged 2 commits into
PowerShell:masterfrom
randomvariable:Fedora24
Jan 6, 2017
Merged

Initial Support for Fedora 24#2738
Mike Richmond (mirichmo) merged 2 commits into
PowerShell:masterfrom
randomvariable:Fedora24

Conversation

@randomvariable

@randomvariable Naadir Jeewa (randomvariable) commented Nov 20, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add support for Fedora 24.

This PR adds initial support for the Fedora distribution, starting with Fedora 24.

Until the next release of PowerShell is compiled against .NET 1.1, the Docker release image uses the CentOS 7 build, but loads in the CentOS 7 version of libicu50 via LD_LIBRARY_PATH.

Closes #1882

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Nov 20, 2016

Copy link
Copy Markdown

Hi Naadir Jeewa (@randomvariable), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@randomvariable

Naadir Jeewa (randomvariable) commented Nov 20, 2016

Copy link
Copy Markdown
Contributor Author

Not added Fedora to https://github.com/PowerShell/PowerShell/blob/master/docker/launch.sh#L32 as it presumably wont work without an initial image on the Docker Hub?

@randomvariable Naadir Jeewa (randomvariable) mentioned this pull request Nov 20, 2016
Merged
@randomvariable
Initial support for Fedora 24
135f76f 
This commit adds initial support for the Fedora distribution,
starting with Fedora 24.

Whereever possible, build tooling for CentOS has been reused.

Until the next release of PowerShell is compiled against .NET 1.1,
the Docker release image uses the CentOS 7 build, but loads
in the CentOS 7 version of `libicu50` via LD_LIBRARY_PATH.
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Dec 10, 2016

Copy link
Copy Markdown

Hi Naadir Jeewa (@randomvariable), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@randomvariable

Naadir Jeewa (randomvariable) commented Dec 10, 2016

Copy link
Copy Markdown
Contributor Author

Was lazily trying to get Travis to rerun tests as it hung last time ^

@randomvariable

Naadir Jeewa (randomvariable) commented Dec 10, 2016

Copy link
Copy Markdown
Contributor Author

Tests passed. This is ready for review.

@xasx

Andreas Schöneck (xasx) commented Dec 17, 2016

Copy link
Copy Markdown

afaict, lgtm

@andyleejordan

Andy Jordan (andyleejordan) commented Dec 22, 2016

Copy link
Copy Markdown
Member

Naadir Jeewa (@randomvariable) for the launch.sh question, that should be able to use locally build Docker images, so I think you can add it there no problem. Dongbo Wang (@daxian-dbw) will need to update the Docker automated build to get updated images on the hub.

andyleejordan
Andy Jordan (andyleejordan) approved these changes Dec 22, 2016
View reviewed changes

@andyleejordan Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this hits all the marks except updated documentation. With Fedora 24 supported, the readme etc. should probably be updated to reflect that, but I approve this.

@andyleejordan

Andy Jordan (andyleejordan) commented Dec 22, 2016

Copy link
Copy Markdown
Member

Naadir Jeewa (@randomvariable) I imagine you did a test past of the build, and tried out the generated package too?

@randomvariable

Naadir Jeewa (randomvariable) commented Dec 22, 2016

Copy link
Copy Markdown
Contributor Author

It's my default shell right now...

@mirichmo
Mike Richmond (mirichmo) merged commit 8262091 into PowerShell:master Jan 6, 2017
@mirichmo Mike Richmond (mirichmo) mentioned this pull request Jan 6, 2017
Merged
@mirichmo

Mike Richmond (mirichmo) commented Jan 6, 2017

Copy link
Copy Markdown
Member

I reverted this PR because it caused a build break on Ubuntu. Details are in #2970.

@andyleejordan Andy Jordan (andyleejordan) mentioned this pull request Jan 9, 2017
Merged
Rob Holt (rjmholt) pushed a commit to rjmholt/PowerShell that referenced this pull request Jan 9, 2017
@randomvariable @rjmholt
Initial Support for Fedora 24 (PowerShell#2738)
98cb006 
* Initial support for Fedora 24
This commit adds initial support for the Fedora distribution,
starting with Fedora 24.

Whereever possible, build tooling for CentOS has been reused.

Until the next release of PowerShell is compiled against .NET 1.1,
the Docker release image uses the CentOS 7 build, but loads
in the CentOS 7 version of `libicu50` via LD_LIBRARY_PATH.

* Update Dockerfile

Fix typos
Andy Jordan (andyleejordan) pushed a commit to andyleejordan/PowerShell that referenced this pull request Jan 12, 2017
@randomvariable @andyleejordan
Initial Support for Fedora 24 (PowerShell#2738)
12442b1 
* Initial support for Fedora 24
This commit adds initial support for the Fedora distribution,
starting with Fedora 24.

Whereever possible, build tooling for CentOS has been reused.

Until the next release of PowerShell is compiled against .NET 1.1,
the Docker release image uses the CentOS 7 build, but loads
in the CentOS 7 version of `libicu50` via LD_LIBRARY_PATH.

* Update Dockerfile

Fix typos
Andy Jordan (andyleejordan) pushed a commit that referenced this pull request Jan 20, 2017
@randomvariable @andyleejordan
Initial Support for Fedora 24 (#2738)
01dfb88 
* Initial support for Fedora 24
This commit adds initial support for the Fedora distribution,
starting with Fedora 24.

Whereever possible, build tooling for CentOS has been reused.

Until the next release of PowerShell is compiled against .NET 1.1,
the Docker release image uses the CentOS 7 build, but loads
in the CentOS 7 version of `libicu50` via LD_LIBRARY_PATH.

* Update Dockerfile

Fix typos
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@randomvariable @mirichmo
Initial Support for Fedora 24 (PowerShell#2738)
677aabd 
* Initial support for Fedora 24
This commit adds initial support for the Fedora distribution,
starting with Fedora 24.

Whereever possible, build tooling for CentOS has been reused.

Until the next release of PowerShell is compiled against .NET 1.1,
the Docker release image uses the CentOS 7 build, but loads
in the CentOS 7 version of `libicu50` via LD_LIBRARY_PATH.

* Update Dockerfile

Fix typos
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@randomvariable @andyleejordan
Initial Support for Fedora 24 (PowerShell#2738)
ae86edd 
* Initial support for Fedora 24
This commit adds initial support for the Fedora distribution,
starting with Fedora 24.

Whereever possible, build tooling for CentOS has been reused.

Until the next release of PowerShell is compiled against .NET 1.1,
the Docker release image uses the CentOS 7 build, but loads
in the CentOS 7 version of `libicu50` via LD_LIBRARY_PATH.

* Update Dockerfile

Fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyleejordan Andy Jordan (andyleejordan) andyleejordan approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw

Assignees

@mirichmo Mike Richmond (mirichmo)

Labels

Review - Needed The PR is being reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@randomvariable @msftclas @xasx @andyleejordan @mirichmo @PowerShellTeam @HemantMahawar