Repository navigation
[release/v7.4] Mirror .NET/runtime ICU version range in PowerShell #27137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Aditya Patwardhan (adityapatwardhan)
wants to merge
1
commit into
PowerShell:release/v7.4
from
adityapatwardhan:backport/release/v7.4/26304-bb44aa1bc
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2125,17 +2125,32 @@ function Get-PackageDependencies | |||||
|
|
||||||
| # These should match those in the Dockerfiles, but exclude tools like Git, which, and curl | ||||||
| $Dependencies = @() | ||||||
|
|
||||||
| # ICU version range follows .NET runtime policy. | ||||||
| # See: https://github.com/dotnet/runtime/blob/3fe8518d51bbcaa179bbe275b2597fbe1b88bc5a/src/native/libs/System.Globalization.Native/pal_icushim.c#L235-L243 | ||||||
| # | ||||||
| # Version range rationale: | ||||||
| # - The runtime supports ICU versions >= the version it was built against | ||||||
| # and <= that version + 30, to allow sufficient headroom for future releases. | ||||||
| # - ICU typically releases about twice per year, so +30 provides roughly | ||||||
| # 15 years of forward compatibility. | ||||||
| # - On some platforms, the minimum supported version may be lower | ||||||
| # than the build version and we know that older versions just works. | ||||||
|
||||||
| # than the build version and we know that older versions just works. | |
| # than the build version and we know that older versions just work. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rationale comment says “supports ICU versions >= the version it was built against and <= that version + 30”, but the implementation explicitly allows versions down to $MinICUVersion (60) which is lower than the build version (74). Please reword the comment to match the actual range being generated (MinICUVersion..(BuildICUVersion+30)) and the .NET runtime behavior described by the linked source.