ThrottleManager: fix IgnoreStop setter to honor assigned value#27107
Open
cuiweixie wants to merge 1 commit intoPowerShell:masterfrom
Open
ThrottleManager: fix IgnoreStop setter to honor assigned value#27107cuiweixie wants to merge 1 commit intoPowerShell:masterfrom
cuiweixie wants to merge 1 commit intoPowerShell:masterfrom
Conversation
The setter always assigned _ignoreStop = true instead of the incoming value, so callers could not set IgnoreStop to false.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a logic bug in the remoting throttle infrastructure where IThrottleOperation.IgnoreStop could not be set to false because the setter always assigned true.
Changes:
- Update
IgnoreStopsetter to assign the incomingvalueto the backing field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures
IgnoreStopcan be set tofalseas intended. The setter previously ignored the assigned value and always set the backing field totrue.Changes
throttlemanager.cs, set_ignoreStopfrom the propertyvalueinstead of a constanttrue.