PSStyle: validate background index against BackgroundColorMap#27106
Open
cuiweixie wants to merge 1 commit intoPowerShell:masterfrom
Open
PSStyle: validate background index against BackgroundColorMap#27106cuiweixie wants to merge 1 commit intoPowerShell:masterfrom
cuiweixie wants to merge 1 commit intoPowerShell:masterfrom
Conversation
FromAnsiColor checked backgroundColor against ForegroundColorMap.Length, which could throw or allow out-of-range values when the two maps differ in length. Use BackgroundColorMap.Length for the background bounds check.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bounds-check bug in PSStyle.MapColorPairToEscapeSequence by validating the background color index against the background color map (instead of the foreground map), preventing incorrect ArgumentOutOfRangeException behavior if the map sizes ever diverge.
Changes:
- Update
MapColorPairToEscapeSequenceto comparebackIndextoBackgroundColorMap.Length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
FromAnsiColorso the background color index is validated againstBackgroundColorMap.Lengthinstead ofForegroundColorMap.Length, matching the map used for conversion and avoiding incorrectArgumentOutOfRangeExceptionbehavior when the two maps differ in size.Changes
PSStyle.cs, comparebackIndextoBackgroundColorMap.Lengthin the background branch.Testing
ForegroundColorMapandBackgroundColorMaplengths can diverge in this codebase.