Skip to content

ConvertTo-Html: assign HtmlEncode result to -Title #27103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cuiweixie wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

ConvertTo-Html: assign HtmlEncode result to -Title #27103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.Commands.Utility/commands/utility/ConvertTo-Html.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ protected override void BeginProcessing()

if (!string.IsNullOrEmpty(_title))
{
WebUtility.HtmlEncode(_title);
_title = WebUtility.HtmlEncode(_title);
}

// This first line ensures w3c validation will succeed. However we are not specifying
Expand Down
9 changes: 9 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Html.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,15 @@ Body Text
$returnString | Should -Be $expectedValue
}

It "ConvertTo-Html -Title HTML-encodes special characters in the document title" {
# Regression: BeginProcessing must assign WebUtility.HtmlEncode(_title) back to _title;
# otherwise the encode result is discarded and raw <, >, &, " appear in <title>.
$title = 'A <B> & C "D"'
$expectedInner = [System.Net.WebUtility]::HtmlEncode($title)
$returnString = ($customObject | ConvertTo-Html -Title $title) -join $newLine
$returnString | Should -Match "<title>$([regex]::Escape($expectedInner))</title>"
}

It "Test ConvertTo-Html pre and post" {
$returnString = ($customObject | ConvertTo-Html -PreContent "Before the object" -PostContent "After the object") -join $newLine
$expectedValue = normalizeLineEnds @"
Expand Down
Loading