Skip to content

Fix csv cmdlets to use default delimiter with -UseCulture:False #27036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evalentini wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix csv cmdlets to use default delimiter with -UseCulture:False #27036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c1dcf4
Fix ConvertTo-Csv/Export-Csv -UseCulture:False to use default comma d…
evalentini Mar 15, 2026
d177819
Merge branch 'master' into fix-useculture-false-26513
evalentini Mar 17, 2026
ae20e25
Merge branch 'master' into fix-useculture-false-26513
evalentini Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/CsvCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1787,12 +1787,11 @@ internal static char SetDelimiter(PSCmdlet cmdlet, string parameterSetName, char
case "UseCulture":
case "CulturePath":
case "CultureLiteralPath":
if (useCulture)
{
// ListSeparator is apparently always a character even though the property returns a string, checked via:
// [CultureInfo]::GetCultures("AllCultures") | % { ([CultureInfo]($_.Name)).TextInfo.ListSeparator } | ? Length -ne 1
delimiter = CultureInfo.CurrentCulture.TextInfo.ListSeparator[0];
}
// ListSeparator is apparently always a character even though the property returns a string, checked via:
// [CultureInfo]::GetCultures("AllCultures") | % { ([CultureInfo]($_.Name)).TextInfo.ListSeparator } | ? Length -ne 1
delimiter = useCulture
? CultureInfo.CurrentCulture.TextInfo.ListSeparator[0]
: ImportExportCSVHelper.CSVDelimiter;

break;
default:
Expand Down
9 changes: 9 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Csv.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@ Describe "ConvertTo-Csv DRT Unit Tests" -Tags "CI" {
$returnObject[2] | Should -BeExactly "`"1`"$($delimiter)`"2`""
}

## https://github.com/PowerShell/PowerShell/issues/26513
It "Test convertto-csv with -UseCulture:`$false uses default comma delimiter" {
$returnObject = $inputObject | ConvertTo-Csv -UseCulture:$false -IncludeTypeInformation
$returnObject.Count | Should -Be 3
$returnObject[0] | Should -BeExactly "#TYPE System.Management.Automation.PSCustomObject"
$returnObject[1] | Should -BeExactly "`"First`",`"Second`""
$returnObject[2] | Should -BeExactly "`"1`",`"2`""
}

It "Test convertto-csv with Delimiter" {
$returnObject = $inputObject | ConvertTo-Csv -Delimiter ";" -IncludeTypeInformation
$returnObject.Count | Should -Be 3
Expand Down