Skip to content

[release/v7.5] Add version in description and pass store task on failure. #26896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TravisEz13 wants to merge 1 commit into
base: release/v7.5
Choose a base branch
from
Open

[release/v7.5] Add version in description and pass store task on failure. #26896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .pipelines/templates/release-MSIX-Publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,15 @@ jobs:

$json.listings.'en-us'.baseListing.releaseNotes = $message

# Add PowerShell version to the top of the description
$description = $json.listings.'en-us'.baseListing.description
$version = "$(ReleaseTag)"
$updatedDescription = "Version: $version`n`n$description"
$json.listings.'en-us'.baseListing.description = $updatedDescription
Write-Verbose -Verbose "Updated description: $updatedDescription"

$json | ConvertTo-Json -Depth 100 | Set-Content $jsonPath -Encoding UTF8
displayName: 'Update Release Notes in JSON'
displayName: 'Add Changelog Link and Version Number to SBJSON'

- task: PowerShell@2
inputs:
Expand Down Expand Up @@ -115,7 +122,8 @@ jobs:

- task: MS-RDX-MRO.windows-store-publish.publish-task.store-publish@3
displayName: 'Publish StoreBroker Package (Stable/LTS)'
condition: and(ne('${{ parameters.skipMSIXPublish }}', 'true'), or(eq('$(STABLE)', 'true'), eq('$(LTS)', 'true')))
condition: and(ne('${{ parameters.skipMSIXPublish }}', 'true'), or(eq(variables['STABLE'], 'true'), eq(variables['LTS'], 'true')))
continueOnError: true
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using continueOnError: true on a critical publishing task is concerning. According to the PR description, this is added "because it always fails," but this suggests an underlying issue that should be investigated rather than suppressed.

Publishing to the Microsoft Store is a critical operation - if it's failing, the pipeline should alert on that failure so it can be investigated. Using continueOnError: true means the pipeline will appear to succeed even if publishing actually fails, which could result in releases not being published without anyone noticing.

Recommended approach:

  1. Investigate why the store-publish task is failing (authentication issues, API problems, configuration errors, etc.)
  2. Fix the root cause
  3. Only use continueOnError: true for non-critical diagnostic steps, not for critical operations like publishing

If there's a legitimate reason why this task should continue on error (e.g., the store has manual approval steps that cause the task to timeout but the submission still succeeds), that should be documented in a comment explaining the rationale.

Copilot generated this review using guidance from repository custom instructions.
inputs:
serviceEndpoint: 'StoreAppPublish-Stable'
appId: '$(AppID)'
Expand All @@ -128,7 +136,8 @@ jobs:

- task: MS-RDX-MRO.windows-store-publish.publish-task.store-publish@3
displayName: 'Publish StoreBroker Package (Preview)'
condition: and(ne('${{ parameters.skipMSIXPublish }}', 'true'), eq('$(PREVIEW)', 'true'))
condition: and(ne('${{ parameters.skipMSIXPublish }}', 'true'), eq(variables['PREVIEW'], 'true'))
continueOnError: true
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as the Stable/LTS publish task - using continueOnError: true on a critical publishing operation masks failures and could result in releases not being published without detection.

This should either:

  1. Have the root cause of failures investigated and fixed, OR
  2. Include a comment explaining why continuing on error is necessary for this specific task

Copilot generated this review using guidance from repository custom instructions.
inputs:
serviceEndpoint: 'StoreAppPublish-Preview'
appId: '$(AppID)'
Expand Down
Loading