Skip to content

Fetch latest ICU release version dynamically#26827

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
kasperk81:patch-2
Feb 19, 2026
Merged

Fetch latest ICU release version dynamically#26827
daxian-dbw merged 2 commits intoPowerShell:masterfrom
kasperk81:patch-2

Conversation

@kasperk81
Copy link
Copy Markdown
Contributor

PR Summary

Updated the build ICU version retrieval to use the latest release from GitHub.

PR Checklist

@kasperk81 kasperk81 requested review from a team and jshigetomi as code owners February 14, 2026 02:31
@kasperk81
Copy link
Copy Markdown
Contributor Author

@daxian-dbw, @TravisEz13: This change allows us to avoid manually updating the ICU build version each year. It’s optional, but if adopted, it will fail fast in case anything unexpected changes.

I don’t anticipate issues, as many automation workflows rely on their release tag format, which has remained stable for years.

Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
It would be so easy to forget about updating $BuildICUVersion if it has to be done manually. Thanks for the improvement!

@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 19, 2026
@daxian-dbw daxian-dbw merged commit cf40400 into PowerShell:master Feb 19, 2026
38 of 39 checks passed
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 9, 2026
@daxian-dbw
Copy link
Copy Markdown
Member

This change makes it required to access an outside endpoint during packaging build, which will be blocked in our packaging pipeline due to the network isolation requirement for Compliance.

The maintainers need to determine if we should revert this change in master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants