Skip to content

Porting Enable-PSRemoting and its Tests #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 12 commits into from
Aug 8, 2017
Merged

Porting Enable-PSRemoting and its Tests #2671

daxian-dbw merged 12 commits into from
Aug 8, 2017

Conversation

@mirichmo
Copy link
Member

@mirichmo mirichmo commented Nov 12, 2016

Fixes #1193 for most scenarios. The remaining scenario to be addressed is the Nano Server bring-up scenario. To continue supporting that scenario, I left the Install-PowerShellRemoting script in place.

This change

  1. Ports Enable-PSRemoting and Disable-PSRemoting to PowerShell Core
  2. Adds side-by-side PowerShell Core remoting support to the PSSessionConfiguration cmdlets and PSRemoting cmdlets.
  3. Ports PSSessionConfiguration tests

This change also introduces a behavioral difference. The PSRemoting and PSSessionConfiguration cmdlets are now context-sensitive and only work for endpoints that match the PowerShell type. For example, Get-PSSessionConfiguration, when run in PowerShell Core, will only return PowerShell Core WinRM endpoints. It will only modify PowerShell Core WinRM endpoints and cannot be used to configure Windows PowerShell endpoints.

@mirichmo mirichmo force-pushed the porting-enable-psremoting branch from 7d27163 to 701bb47 Compare November 14, 2016 17:47
@vors vors closed this Nov 14, 2016
@vors vors reopened this Nov 14, 2016
@mirichmo mirichmo added this to the 6.0.0-alpha.14 milestone Nov 22, 2016
@PowerShellTeam PowerShellTeam added the Review - Needed The PR is being reviewed label Nov 22, 2016
@lzybkr lzybkr modified the milestones: 6.0.0-beta, 6.0.0-alpha.14 Dec 8, 2016
@chunqingchen
Copy link
Contributor

chunqingchen commented Jan 11, 2017

Can you please resolve the conflict?

@mirichmo
Copy link
Member Author

mirichmo commented Jan 11, 2017

At some point. I'm trying to find time to resolve the test failures.

@chunqingchen
Copy link
Contributor

chunqingchen commented Jan 11, 2017

cool !

@mirichmo mirichmo force-pushed the porting-enable-psremoting branch from 701bb47 to 4f54950 Compare February 9, 2017 01:55
@mirichmo mirichmo force-pushed the porting-enable-psremoting branch 2 times, most recently from e9168ff to cb2a7e7 Compare February 28, 2017 18:04
@mirichmo mirichmo force-pushed the porting-enable-psremoting branch 2 times, most recently from 0f08a9f to 7ee2f3b Compare March 17, 2017 23:20
@daxian-dbw daxian-dbw requested a review from PaulHigin April 11, 2017 16:48
@SteveL-MSFT SteveL-MSFT modified the milestones: 6.0.0-beta1, 6.0.0-beta May 1, 2017
@iSazonov iSazonov mentioned this pull request May 5, 2017
Closed
@mirichmo mirichmo mentioned this pull request Jul 18, 2017
Closed
@SteveL-MSFT SteveL-MSFT mentioned this pull request Jul 18, 2017
Closed
@PaulHigin
Copy link
Contributor

PaulHigin commented Jul 20, 2017

@mirichmo I am not sure how I missed this being assigned to me as a reviewer. But I will review it today.

@mirichmo
Copy link
Member Author

mirichmo commented Jul 20, 2017

The tests aren't passing yet so it still needs some work. You are always welcome to take a look though

@PaulHigin
Copy link
Contributor

PaulHigin commented Jul 24, 2017

@mirichmo I went through the code changes and made some minor changes in my fork. I also made some fixes in the test file. Overall I think this looks good and is the right way to implement WinRM based remoting enabling and endpoint management. Please see the patch file I sent you offline that has my minor changes.

@mirichmo mirichmo force-pushed the porting-enable-psremoting branch from 7ee2f3b to b1e93ac Compare July 26, 2017 21:36
@mirichmo mirichmo force-pushed the porting-enable-psremoting branch from 6b2ed25 to 1db21fd Compare August 7, 2017 16:54
@mirichmo
Copy link
Member Author

mirichmo commented Aug 7, 2017

@daxian-dbw This is ready for merge now.

@daxian-dbw daxian-dbw merged commit 515a999 into PowerShell:master Aug 8, 2017
@daxian-dbw daxian-dbw mentioned this pull request Aug 8, 2017
Closed
@iSazonov
Copy link
Collaborator

iSazonov commented Aug 9, 2017 •
edited
Loading

This change also introduces a behavioral difference

It seems we need update docs - should we set the label?

@iSazonov iSazonov removed the Review - Needed The PR is being reviewed label Aug 9, 2017
@daxian-dbw daxian-dbw added the Documentation Needed in this repo Documentation is needed in this repo label Aug 9, 2017
@daxian-dbw
Copy link
Member

daxian-dbw commented Aug 9, 2017

@iSazonov good point. I added the label to both this PR and the issue.

@mirichmo mirichmo deleted the porting-enable-psremoting branch August 9, 2017 16:47
@adityapatwardhan adityapatwardhan mentioned this pull request Aug 9, 2017
Closed
@TravisEz13 TravisEz13 mentioned this pull request Aug 24, 2017
Merged
This was referenced Sep 22, 2017
Closed
Closed
@joeyaiello joeyaiello mentioned this pull request Oct 15, 2018
Closed
@joeyaiello joeyaiello removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@daxian-dbw daxian-dbw daxian-dbw approved these changes

+1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daxian-dbw daxian-dbw

Labels

None yet

Projects

None yet

Milestone

6.0.0-GA

Development

Successfully merging this pull request may close these issues.