-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Bring Release Changes from v7.6.0-preview.6 Release #26626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eate Remove the condition duplication in YAML for MSIX create ---- #### AI description (iteration 1) #### PR Classification This pull request is a code cleanup that removes redundant condition logic from the MSIX creation pipeline configuration. #### PR Summary The changes streamline the YAML configuration to eliminate duplicated conditional checks, enhancing clarity in the pipeline setup. - `/.pipelines/templates/package-create-msix.yml`: Removed the duplicate `condition: failed()` line from the job configuration. - `/.pipelines/templates/package-create-msix.yml`: Applied a minor cosmetic adjustment to the `displayName` entry. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Update the ThirdPartyNotices file ---- #### AI description (iteration 1) #### PR Classification This pull request is a documentation update focused on refreshing and standardizing the license and dependency metadata in the ThirdPartyNotices file. #### PR Summary The pull request revises the content of the `ThirdPartyNotices.txt` file by streamlining the MIT license text and updating dependency version numbers and copyright notices. - `ThirdPartyNotices.txt`: Consolidated redundant MIT license blocks into a consistent format. - `ThirdPartyNotices.txt`: Updated multiple library version numbers (e.g. components upgraded from 9.0.9 to 10.0.0 and version changes for System.ServiceModel and Microsoft.Win32 libraries). - `ThirdPartyNotices.txt`: Adjusted several dependency entries, including renaming and version updates (e.g. Markdig.Signed from 0.42.0 to 0.43.0). - `ThirdPartyNotices.txt`: Revised copyright statements (e.g. Unicode copyright updated from 1991–2022 to 1991–2024). <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Do not install dotnet-format tool for official builds ---- #### AI description (iteration 1) #### PR Classification Configuration change to skip installing the dotnet-format tool during official builds. #### PR Summary This pull request updates the build script to conditionally install the .NET SDK and dotnet-format tool only when not running in an official build environment. - **`/build.psm1`**: Wraps the .NET installation block in an `if (-not $env:TF_BUILD)` condition, preventing the installation of the dotnet-format tool on official builds. - **`/build.psm1`**: Maintains existing behavior for non-official builds while ensuring that official builds remain streamlined. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
…ved in merging Add ob_restore_phase false to cloning which was removed in merging ---- #### AI description (iteration 1) #### PR Classification Pipeline configuration update that restores a previously removed parameter. #### PR Summary This pull request reintroduces the `ob_restore_phase` parameter with a value of false in the cloning step of the CI/CD pipeline configuration. - Modified `/.pipelines/templates/packaging/windows/package.yml` to add `ob_restore_phase: false` in the clone template parameters. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Fix Windows Signing stage and MSIX create stage ---- #### AI description (iteration 1) #### PR Classification Bug fix addressing issues in the Windows Signing and MSIX creation stages. #### PR Summary This pull request fixes the Windows signing and MSIX package creation processes. It ensures that dotnet is available early in the bootstrap and corrects YAML condition expressions for package tasks. - `build.psm1`: Moved the dotnet availability check to an earlier section, ensuring that .NET SDK dependencies are met before proceeding. - `.pipelines/templates/package-create-msix.yml`: Updated condition expressions to use variable dictionary references for both preview and stable/LTS package tasks. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request brings release changes from the v7.6.0-preview.6 release into the main branch, consolidating multiple merged PRs that were part of the preview release. The changes focus on pipeline reliability improvements, build configuration updates, and dependency version updates to prepare for the official release.
Key changes:
- Improved Azure DevOps pipeline condition syntax for better reliability
- Refactored dotnet-format installation to skip in CI builds
- Updated third-party dependencies from version 9.0.9 to 10.0.0
- Added comprehensive changelog documentation for preview.6 release
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
build.psm1 |
Moved Find-Dotnet call earlier and wrapped dotnet-format installation in check to skip for Azure Pipelines builds ($env:TF_BUILD), per guideline 1000003 to avoid installing unnecessary tools in official builds |
ThirdPartyNotices.txt |
Updated package versions (Markdig 0.42.0→0.43.0, Microsoft.Bcl.AsyncInterfaces 9.0.9→10.0.0, and ~50 other System.* packages 9.0.9→10.0.0), standardized MIT license text formatting across all entries |
CHANGELOG/preview.md |
Added new section documenting v7.6.0-preview.6 release with engine updates, cmdlet changes, tooling improvements, tests, and 27 build/packaging enhancements in collapsible details section |
.pipelines/templates/release-MSIX-Publish.yml |
Fixed condition syntax from $(VAR) to variables['VAR'] for STABLE, LTS, and PREVIEW checks in StoreBroker publish tasks for more robust variable evaluation |
.pipelines/templates/packaging/windows/package.yml |
Added ob_restore_phase: false parameter to cloneToOfficialPath template call for explicit OneBranch restore phase control in build-only job |
.pipelines/templates/package-create-msix.yml |
Fixed condition syntax from $(VAR) to variables['VAR'] for PREVIEW, STABLE, and LTS checks; removed duplicate erroneous condition: failed() line from Stable/LTS task |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR Summary
This pull request includes several important updates across build pipelines, packaging, and documentation. The changes focus on improving pipeline condition syntax for reliability, updating build steps for better dependency handling, and documenting the latest preview release.
Pipeline Condition Improvements:
.pipelines/templates/package-create-msix.ymland.pipelines/templates/release-MSIX-Publish.ymlto usevariables['VAR_NAME']instead of$(VAR_NAME)for more robust variable referencing in Azure DevOps pipelines. [1] [2] [3] [4]condition: failed()line from the MSIX pipeline template to streamline task execution.Build Script Enhancements:
Find-Dotnetearlier in theStart-PSBootstrapfunction inbuild.psm1to ensure the .NET SDK is available before installing global tools, and adjusted logic to only install global tools outside of Azure Pipelines.Packaging Pipeline Updates:
ob_restore_phase: falseparameter to thecloneToOfficialPath.ymltemplate step in the Windows packaging pipeline for improved control over the restore phase.Documentation:
CHANGELOG/preview.mdfor version 7.6.0-preview.6, listing engine updates, cmdlet changes, tooling improvements, test updates, and detailed build/packaging enhancements.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header