Documentation improvement for get-changed-files action#26531
Open
Documentation improvement for get-changed-files action#26531
Conversation
- Fix README.md: Change "Handles up to 100 changed files" to "Handles all changed files (no limit)" - Fix README.md: Add actions/checkout step to basic usage example - Fix README.md: Improve limitations section with better filter pattern description - Fix action.yml: Change filter logic to use case-sensitive comparison for consistency with git Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Apply changes based on pull request review comments
Apply code review feedback from get-changed-files action PR #26529
Nov 25, 2025
Member
|
@copilot the filter was supposed to be case insensitive, revert that change and add a comment to make that clear |
Reverts the case-sensitivity change per review feedback. The filter is intentionally case-insensitive for cross-platform consistency. Added comment to clarify this design decision. Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Contributor
Author
TravisEz13
changed the title
TravisEz13
approved these changes
Nov 25, 2025
TravisEz13
added
the
CL-Docs
SeeminglyScience
approved these changes
Nov 25, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the documentation for the get-changed-files reusable composite action. The changes clarify pagination behavior, filter pattern support, and add a necessary prerequisite step to the usage example. This documentation-only change makes the action easier to understand and use correctly.
Key changes:
- Clarifies that the action handles all changed files without limits (pagination support was already implemented)
- Adds explicit case-insensitive filter matching comment in the action code
- Includes checkout step in usage example (required for local action references)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/actions/infrastructure/get-changed-files/action.yml |
Adds inline comment documenting case-insensitive filter behavior for cross-platform consistency |
.github/actions/infrastructure/get-changed-files/README.md |
Updates documentation to clarify no file limit, adds checkout step to usage example, and provides clearer explanation of supported filter patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
microsoft-github-policy-service
bot
added
the
Review - Needed
Contributor
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request updates the reusable composite GitHub Action for retrieving changed files in a pull request. The main improvements include removing the file count limit, clarifying filter pattern support, and ensuring case-insensitive filter matching for consistency across platforms.
Changed file retrieval and filtering:
.github/actions/infrastructure/get-changed-files/README.md)*.ext) and path prefix matching are supported; complex glob or regex patterns are not. (.github/actions/infrastructure/get-changed-files/README.md).github/actions/infrastructure/get-changed-files/action.yml)Documentation improvements:
.github/actions/infrastructure/get-changed-files/README.md)PR Context
Implements actionable feedback from automated code review on PR #26529. The case-insensitive filter behavior is intentional for cross-platform consistency, and a clarifying comment was added to document this design decision.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.