Replace manual temp directory creation with New-TempFolder helper by Copilot · Pull Request #26443 · PowerShell/PowerShell

Copilot · 2025-11-13T17:48:49Z

PR Summary

Eliminates code duplication in New-MacOsDistributionPackage by replacing manual temp directory creation with the existing New-TempFolder helper function.

PR Context

The New-MacOsDistributionPackage function manually created temp directories instead of using New-TempFolder, which is used throughout the rest of the codebase (e.g., in New-MacOSPackage).

Before:

$tempDir = Join-Path ([System.IO.Path]::GetTempPath()) ([System.IO.Path]::GetRandomFileName())
New-Item -ItemType Directory -Path $tempDir -Force > $null

After:

$tempDir = New-TempFolder

Net: -1 line. The New-TempFolder helper includes a Test-Path check before creation, making it marginally safer than the original -Force approach.

Addresses #26441 (comment)

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge.
Breaking changes
- None
User-facing changes
- Not Applicable
Testing - New and feature
- N/A or can only be tested interactively

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/repos/PowerShell/PowerShell/pulls/26441/comments
- Triggering command: curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

This section details on the original issue you should resolve

<issue_title>Fix code duplication in packaging</issue_title>
<issue_description>### Prerequisites

Write a descriptive title.

Make sure you are able to repro it on the latest released version

Search the existing issues.

Refer to the FAQ.

Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce

Address this comment #26441 (comment)

Expected behavior
Address this comment https://github.com/PowerShell/PowerShell/pull/26441#discussion_r2524372043
Actual behavior
Address this comment https://github.com/PowerShell/PowerShell/pull/26441#discussion_r2524372043
Error details
Environment data
Address this comment https://github.com/PowerShell/PowerShell/pull/26441#discussion_r2524372043
Visuals

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Fix code duplication in packaging #26442

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ction Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>

Copilot

Pull Request Overview

This PR eliminates code duplication by replacing manual temporary directory creation with the existing New-TempFolder helper function in the New-MacOsDistributionPackage function.

Replaces two lines of manual temp directory creation with a single call to New-TempFolder
Makes the code more consistent with other functions in the same module (e.g., New-MacOSPackage)
Improves safety by using the helper's Test-Path check instead of -Force

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

kilasuit · 2025-11-22T22:02:59Z

@TravisEz13 this pr isn't the right way for this direction of travel overall & I'm not quite happy with copliot having used cpu time on this for such little a gain in the grand scheme of things & as such I'd like it if we closed this.

Instead we should have a new cmdlet New-TemporaryDirectory much like New-TemporaryFile in the Microsoft.PowerShell.Utility module that can be called from in the same way in tooling like this & also aid in further reducing code duplication in this repo and for others down the line. It could have New-TempFolder as an alias and possibly there's other similar useful aliases that could be added too & would be a better way forward overall & has been approved by the Cmdlets WG in #25754

Hope that makes sense

Unrepentant-Atheist · 2025-11-23T11:12:59Z

Copilot is stupid.

Initial plan

cf0572b

Copilot AI assigned Copilot and TravisEz13 Nov 13, 2025

Copilot started work on behalf of TravisEz13 November 13, 2025 17:49 View session

Replace manual temp directory creation with New-TempFolder helper fun…

17369d5

…ction Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix code duplication in packaging~~ Replace manual temp directory creation with New-TempFolder helper Nov 13, 2025

Copilot finished work on behalf of TravisEz13 November 13, 2025 18:01

Copilot AI requested a review from TravisEz13 November 13, 2025 18:01

TravisEz13 requested a review from Copilot November 13, 2025 21:48

TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 13, 2025

Copilot started reviewing on behalf of TravisEz13 November 13, 2025 21:48 View session

TravisEz13 marked this pull request as ready for review November 13, 2025 21:49

TravisEz13 requested review from a team and jshigetomi as code owners November 13, 2025 21:49

Copilot finished reviewing on behalf of TravisEz13 November 13, 2025 21:50

Copilot AI reviewed Nov 13, 2025

View reviewed changes

microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Nov 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace manual temp directory creation with New-TempFolder helper#26443

Replace manual temp directory creation with New-TempFolder helper#26443
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-code-duplication-packaging

Copilot AI commented Nov 13, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

kilasuit commented Nov 22, 2025

Uh oh!

Unrepentant-Atheist commented Nov 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

I tried to connect to the following addresses, but was blocked by firewall rules:

Steps to reproduce

Expected behavior

Actual behavior

Error details

Environment data

Visuals

Comments on the Issue (you are @copilot in this section)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

kilasuit commented Nov 22, 2025

Uh oh!

Unrepentant-Atheist commented Nov 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Nov 13, 2025 •

edited

Loading