-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update the WCF packages to the latest version that is compatible with v4.10.3 #26406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes commented-out package references and updates System.ServiceModel packages to version 10.0.0-rc.2.final.
- Removes commented-out package references that were causing NU1510 warnings in System.Management.Automation.csproj
- Updates System.ServiceModel packages from v4.10.3 to v10.0.0-rc.2.final (major version upgrade)
- Removes several System.ServiceModel packages (Duplex, Security, Private.ServiceModel) and associated comments about version pinning
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/System.Management.Automation/System.Management.Automation.csproj | Cleans up commented-out package references for DiagnosticSource, IO.FileSystem.AccessControl, Security.AccessControl, and Text.Encoding.CodePages |
| src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj | Updates System.ServiceModel packages from v4.10.3 to v10.0.0-rc.2.final and removes Duplex, Security, and Private.ServiceModel packages along with their explanatory comments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR Summary
Fix #19238
PackageReferenceitems that were commented out.10.0.0-rc.2.final.The
10.0.0-rc.2.finalversionServiceModelpackages are backward compatible:The packages
System.ServiceModel.Duplex,System.ServiceModel.Security, andSystem.Private.ServiceModelare discontinued.The package
System.ServiceModel.Primitivesships 3 facade assembliesSystem.ServiceModel.dllSystem.ServiceModel.Duplex.dllSystem.ServiceModel.Security.dllThe package
System.Private.ServiceModelis no longer needed, as every package now carries its own implementation.I have verified that the
ActiveDirectorymodule can be correctly imported with in PowerShell built with the10.0.0-rc.2.finalWCF packages.Before this change, the
*ServiceModel*assemblies carried by PowerShell are:After this change, the
*ServiceModel*assemblies carried by PowerShell are:The difference of Before vs. After is shown below. The
System.Private.ServiceModel.dllis no longer needed with the latest version, and theSystem.ServiceModel.NetFramingBase.dllis a new dependency of theSystem.ServiceModel.NetTcp.dll.