Skip to content

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Oct 29, 2025

PR Summary

Make the following experimental features stable per the PMs and maintainers' decision:

  • PSNativeWindowsTildeExpansion
  • PSRedirectToVariable
  • PSSubsystemPluginModel

Also clean up the related tests. There are some whitespace-only changes to tests, so it's easier to review by ignoring the whitespace changes: https://github.com/PowerShell/PowerShell/pull/26348/files?w=1

Copilot AI review requested due to automatic review settings October 29, 2025 22:29
@daxian-dbw daxian-dbw requested review from a team and jshigetomi as code owners October 29, 2025 22:29
@daxian-dbw daxian-dbw added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log BackPort-7.6.x-Consider labels Oct 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR promotes four experimental features to mainstream by removing their experimental feature gates. These features were previously behind experimental flags and are now enabled by default.

Key Changes:

  • Removed experimental feature gates for PSRedirectToVariable, PSNativeWindowsTildeExpansion, and PSSubsystemPluginModel
  • Removed experimental feature metadata and checks from the engine
  • Updated tests to remove conditional skipping based on experimental feature states
  • Fixed indentation inconsistencies in test files

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/tools/TestMetadata.json Removed experimental feature entries that are now mainstream
test/powershell/Modules/Microsoft.PowerShell.Utility/Set-Variable.Tests.ps1 Removed experimental feature checks and test skipping logic for PSRedirectToVariable
test/powershell/Language/Scripting/NativeExecution/NativeWindowsTildeExpansion.Tests.ps1 Removed experimental feature assertion and fixed indentation
test/powershell/Language/Parser/RedirectionOperator.Tests.ps1 Removed experimental feature check for PSRedirectToVariable
src/System.Management.Automation/engine/runtime/Operations/MiscOps.cs Removed experimental feature guards for PSRedirectToVariable, making variable redirection always available
src/System.Management.Automation/engine/Subsystem/Commands/GetPSSubsystemCommand.cs Removed experimental attribute from Get-PSSubsystem cmdlet
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs Removed experimental feature check for PSNativeWindowsTildeExpansion
src/System.Management.Automation/engine/InitialSessionState.cs Made Get-PSSubsystem cmdlet available by default instead of conditionally
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs Removed experimental feature definitions for promoted features
src/Microsoft.PowerShell.Commands.Utility/commands/utility/Var.cs Removed experimental attribute from Append parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@daxian-dbw daxian-dbw merged commit 943257b into PowerShell:master Oct 30, 2025
34 checks passed
@daxian-dbw daxian-dbw deleted the exp_feat_2 branch October 30, 2025 21:26
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Oct 30, 2025

📣 Hey @@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

pwshBot pushed a commit to pwshBot/PowerShell that referenced this pull request Oct 30, 2025
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Nov 19, 2025
The following experimental features are made stable:
- PSNativeWindowsTildeExpansion
- PSRedirectToVariable
- PSSubsystemPluginModel
SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
The following experimental features are made stable:
- PSNativeWindowsTildeExpansion
- PSRedirectToVariable
- PSSubsystemPluginModel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.6.x-Migrated CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants