Make the experimental feature PSFeedbackProvider stable
#26343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
requested review from
SeeminglyScience,
TravisEz13,
adityapatwardhan and
Copilot
daxian-dbw
added
the
CL-General
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy suggestion framework that was replaced by the extensible feedback provider system. The changes eliminate the hard-coded suggestion mechanism and its associated experimental feature flag (PSFeedbackProvider), consolidating on the newer feedback provider approach.
- Removes the
PSFeedbackProviderexperimental feature flag and related legacy suggestion infrastructure - Deletes legacy suggestion methods and related enums from
HostUtilities.cs - Removes conditional logic that checked the experimental feature flag and always uses the feedback provider
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/System.Management.Automation/resources/SuggestionStrings.resx | Removes the legacy suggestion string resource that was used by the old suggestion framework |
| src/System.Management.Automation/engine/hostifaces/HostUtilities.cs | Removes legacy suggestion infrastructure including SuggestionMatchType enum, suggestion initialization methods, and GetSuggestion methods along with unused imports |
| src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs | Removes the PSFeedbackProvider experimental feature constant and its registration |
| src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHost.cs | Removes conditional logic and the EvaluateSuggestions method, always using EvaluateFeedbacks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adityapatwardhan
approved these changes
Oct 30, 2025
iSazonov
reviewed
Oct 30, 2025
TravisEz13
approved these changes
Oct 30, 2025
TravisEz13
approved these changes
Oct 30, 2025
Contributor
|
📣 Hey @@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 20, 2025
9 tasks
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Per the decision of PMs and maintainers, this PR makes the experimental feature
PSFeedbackProviderstable.It involves quite some cleanup changes as the old suggestion framework is now removed.