Fix linux_packaging job being skipped when only packaging files change#26315
Fix linux_packaging job being skipped when only packaging files change#26315TravisEz13 merged 7 commits intomasterfrom
Conversation
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
|
@copilot |
…cies Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where the linux_packaging job was being skipped when only packaging-related files changed. The solution removes the dependency on ci_build and makes the Linux packaging action perform its own build, following the same pattern as Windows packaging.
Key changes:
- Removed
ci_builddependency fromlinux_packagingjob - Updated Linux packaging action to build and package in a single step
- Enhanced path filters to include Linux-specific packaging paths
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
.github/workflows/linux-ci.yml |
Removed ci_build from linux_packaging dependencies to allow it to run independently |
.github/actions/test/linux-packaging/action.yml |
Replaced artifact download/extraction logic with combined build and package step |
.github/instructions/build-and-packaging-steps.instructions.md |
Added comprehensive documentation of the build/packaging pattern |
.github/actions/infrastructure/path-filters/action.yml |
Extended packaging change detection to include Linux CI workflow and test paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
📣 Hey @@Copilot, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
PowerShell#26315) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
PowerShell#26315) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Plan: Make linux_packaging independent of ci_build
Problem:
linux_packagingjob depends onci_buildpackagingChanged=truebutsource=false),ci_buildis skippedlinux_packagingto also be skipped due to the dependencySolution:
.github/workflows/linux-ci.ymlto removeci_builddependency fromlinux_packaging.github/actions/test/linux-packaging/action.ymlto do its own build instead of downloading artifactswindows-packaging-reusable.ymlwhich does its own buildlinux_packagingonly depends onchangesjobChanges Made:
ci_buildfromlinux_packagingjob dependencies inlinux-ci.ymllinux-packagingaction to:Start-PSBuild+Invoke-CIFinishStart-PSBootstrap -Scenario Packageto install packaging dependencies (fpm, rpmbuild, etc.)Sync-PSTagscalls (already handled byInvoke-CIInstall)-PSModuleRestoreparameter (now default behavior)path-filtersto include:.github/workflows/linux-ci.yml(was only including windows-ci.yml)test/packaging/linux/(was only including windows tests)Result:
The
linux_packagingjob will now run wheneverpackagingChanged=true, regardless of whethersource=trueorci_buildruns. This matches the behavior of the Windows packaging workflow.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.