Repository navigation
Mirror .NET/runtime ICU version range in PowerShell - #26304
Conversation
|
For discussion. Could we take these constants from this file automatically? |
I don't know how to parse C source in PowerShell. Manual parsing sounds like a bad idea. Also, |
We should not assume what platform we are building on. |
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
Travis Plunk (@TravisEz13), this is agnostic of build platform? Or can you clarify what you meant? |
We should be agnostic of build platform. So, if we do pull any information in, it needs to be from public .NET information. |
I’m happy with the current state of the PR, where we align with the version range used by the .NET runtime; which I believe you’re also okay with. The |
It would be wonderful if .NET exposed this and we could generate the code, but otherwise this seems like a step forward. |
|
LGTM, but packaging has been undergoing some changes. CI is broken. I have a PR to fix it. We need to take that PR first and rerun tests. |
|
Travis Plunk (@TravisEz13), if it looks good, can this be merged? Will it be part of the upcoming release? |
|
kasperk81 we have all the changes to the packaging commited that we expect. I'll run the CI again and verify. |
|
Travis Plunk (@TravisEz13) i've fixed the typo from suggestion #26304 (comment). can you rerun the CI? |
|
Approved for backport |
ci: update to PowerShell 7.6.6 This resolves the ICU version issue, because they now support a wide range: PowerShell/PowerShell#26304
ci: update to PowerShell 7.6.6 This resolves the ICU version issue, because they now support a wide range: PowerShell/PowerShell#26304
ci: update to PowerShell 7.6.6 This resolves the ICU version issue, because they now support a wide range: PowerShell/PowerShell#26304
ci: update to PowerShell 7.6.6 This resolves the ICU version issue, because they now support a wide range: PowerShell/PowerShell#26304
ci: update to PowerShell 7.6.6 This resolves the ICU version issue, because they now support a wide range: PowerShell/PowerShell#26304
ci: update to PowerShell 7.6.6 This resolves the ICU version issue, because they now support a wide range: PowerShell/PowerShell#26304
ci: update to PowerShell 7.6.6 This resolves the ICU version issue, because they now support a wide range: PowerShell/PowerShell#26304
Rollup merge of #163849 - cuviper:pwsh-7.6.6, r=ubiratansoares ci: update to PowerShell 7.6.6 This resolves the ICU version issue, because they now support a wide range: PowerShell/PowerShell#26304
ci: update to PowerShell 7.6.6 This resolves the ICU version issue, because they now support a wide range: PowerShell/PowerShell#26304
PR Summary
The .NET runtime defines ICU version ranges instead of tracking exact “running” versions.
This PR mirrors that approach in PowerShell: rather than hardcoding specific ICU versions, it provides headroom above the build version so Debian packages flow smoothly and remain compatible across a range of ICU versions.
Better fix for #25865.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header