Fix build to only enable ready-to-run for the Release configuration#26290
Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom Oct 23, 2025
Merged
Fix build to only enable ready-to-run for the Release configuration#26290daxian-dbw merged 2 commits intoPowerShell:masterfrom
daxian-dbw merged 2 commits intoPowerShell:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the build configuration to enable ready-to-run compilation only for Release builds, preventing debugging issues in Debug builds. Previously, ready-to-run was enabled for all configurations when AppDeployment was set to SelfContained, which made it impossible to debug the code in Debug configuration.
Key changes:
- Split the
AppDeploymentproperty group to separate ready-to-run settings from other self-contained deployment settings - Added a configuration condition to enable ready-to-run only when both
AppDeploymentisSelfContainedandConfigurationisRelease
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
daxian-dbw
added
the
CL-BuildPackaging
TravisEz13
approved these changes
Oct 23, 2025
Member
|
marked for backport because I'm not sure how far back this bug was introduced. |
Contributor
|
📣 Hey @@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Oct 29, 2025
9 tasks
Member
|
Not applicable to 7.4 |
5 tasks
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 18, 2025
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 18, 2025
9 tasks
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
kilasuit
pushed a commit
to kilasuit/PowerShell
that referenced
this pull request
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix build to only enable ready-to-run for the Release configuration.
Currently,
Start-PSBuildwill enable ready-to-run even for 'Debug' configuration, which makes it impossible to debug the code. This PR fixes it to only enable ready-to-run for Release configuration.