Use Environment.TickCount64 in GetUptimeCommand#26151
Use Environment.TickCount64 in GetUptimeCommand#26151xtqqczze wants to merge 3 commits intoPowerShell:masterfrom
Environment.TickCount64 in GetUptimeCommand#26151Conversation
Use the .NET Core 3.0 API `Environment.TickCount64` instead of `Stopwatch`
|
@xtqqczze This is more difficult area than might be expected.
|
|
@iSazonov Does dotnet/runtime#77945 mean these changes are a change in behavior? |
|
Yes, this should correct the difference on different systems. |
|
So these changes are a fix for #18469? |
|
One step in this direction. What would be ideal, I described above. |
|
The cmdlet is documented to "return the time elapsed since the last boot of the operating system" So if these changes align with this, then I think that is sufficient for this PR.
This would be a new feature and could be implemented separately. |
|
This cmdlet was presented as an experimental one to get feedback. After some issues and user expectations have been identified, this cmdlet can be fixed as I described, but a fix in Runtime is required before. |
I see there is now PR: dotnet/runtime#119443 |
|
Waiting on dotnet/runtime#119443 |
|
I suggest to close the PR because we need not only update from .Net but also we should redesign the cmdlet based on feedback we got in last years. |
It does not look like this will be happening anytime soon. |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
Environment.TickCount64instead ofStopwatch.cc: @iSazonov