Skip to content

Add Delimiter parameter to Get-Clipboard #26134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 3 commits into from
Oct 15, 2025
Merged

Add Delimiter parameter to Get-Clipboard #26134

iSazonov merged 3 commits into from
Oct 15, 2025

Conversation

@MartinGC94
Copy link
Contributor

@MartinGC94 MartinGC94 commented Oct 1, 2025 •
edited
Loading

PR Summary

This PR adds a Delimiter parameter to Get-Clipboard allowing users to customize the delimiters used to split the content.
This was discussed in this issue: #25480
Note that I made the parameter a string array, rather than string. The reason for this is that it allows users to set a default value of

"`r`n", "`n"

to handle both Windows and Linux line endings. If it was just a single string you'd have to be aware of the line endings before running the command.

PR Context

Fixes #25480

PR Checklist

@MartinGC94 MartinGC94 mentioned this pull request Oct 1, 2025
Closed
2 tasks
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 2, 2025
@iSazonov
Copy link
Collaborator

iSazonov commented Oct 2, 2025

We could discuss a completer for better UX with values like Default (platform default), WindowsEndOfLine, UnixEndOfLine.

@MartinGC94
Copy link
Contributor Author

MartinGC94 commented Oct 2, 2025

@iSazonov I have added a delimiter completer. Where do we want to place these kinds of completers in the solution? Within the project that uses them? Or within the System.Management.Automation project under CommandCompletion? I noticed we already have a "ScopeArgumentCompleter" there but if we want to have a bunch of completer attributes then it might be worth creating a dedicated folder/namespace for that.

@iSazonov
Copy link
Collaborator

iSazonov commented Oct 3, 2025

Where do we want to place these kinds of completers in the solution? Within the project that uses them?

Yes. It is good if we will decouple in-box modules in future.

@iSazonov
Copy link
Collaborator

iSazonov commented Oct 3, 2025

@MartinGC94 Please fix CodeFactor doc issue.

@iSazonov
Copy link
Collaborator

iSazonov commented Oct 3, 2025

/azp run PowerShell-Windows-Packaging-CI, PowerShell-CI-linux-packaging

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 3, 2025

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Oct 10, 2025
@iSazonov iSazonov merged commit 9c5ac7d into PowerShell:master Oct 15, 2025
36 of 37 checks passed
@iSazonov iSazonov removed the Review - Needed The PR is being reviewed label Oct 15, 2025
@iSazonov iSazonov self-assigned this Oct 15, 2025
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Oct 15, 2025 •
edited by unfurl-links bot
Loading

📣 Hey @@MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Dec 4, 2025
@MartinGC94 @adityapatwardhan
Add Delimiter parameter to Get-Clipboard (PowerShell#26134)
3f3eb8b
@adityapatwardhan adityapatwardhan mentioned this pull request Dec 4, 2025
Merged
9 tasks
SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
@MartinGC94 @SIRMARGIN
Add Delimiter parameter to Get-Clipboard (PowerShell#26134)
9e16d7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@iSazonov iSazonov

Labels

Backport-7.6.x-Migrated CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Get-Clipboard able to handle any line endings

4 participants

@MartinGC94 @iSazonov @SteveL-MSFT @adityapatwardhan