Change the default feedback provider timeout from 300ms to 1000ms#25910
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Aug 26, 2025
Merged
Change the default feedback provider timeout from 300ms to 1000ms#25910daxian-dbw merged 1 commit intoPowerShell:masterfrom
daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
daxian-dbw
added
the
CL-General
kilasuit
approved these changes
Aug 25, 2025
Collaborator
|
@daxian-dbw - Approving as this is a simple enough change. |
iSazonov
approved these changes
Aug 26, 2025
Collaborator
|
/azp run PowerShell-CI-linux-packaging,PowerShell-Windows-Packaging-CI |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
StevenBucher98
approved these changes
Aug 26, 2025
Collaborator
StevenBucher98
left a comment
StevenBucher98
left a comment
There was a problem hiding this comment.
I am ok with increasing the timeout
Contributor
|
📣 Hey @@daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #25863
The WinGet feedback provider has perf regression and now cannot return results within 300ms. See #25863 (comment) for details.
This PR changes the default feedback provider timeout from 300ms to 1000ms to allow the WinGet feedback provider to work.
Note that this doesn't mean a user will always wait for 1 second.
This is a short-term fix. In the long term, we need to improve the UI of feedback provider to allow a much larger default timeout (tracked by #25909).
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header