Skip to content

Use [string] type accelerator - #25902

Open
xtqqczze wants to merge 1 commit into
PowerShell:masterfrom
xtqqczze:ps-TypeAccelerators-string
Open

Use [string] type accelerator#25902
xtqqczze wants to merge 1 commit into
PowerShell:masterfrom
xtqqczze:ps-TypeAccelerators-string

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Use the [string] type accelerator to simplify references to the System.String class.

This also aligns with the canonical lowercase capitalization used for the type accelerator:

PowerShell/test/powershell/Language/Parser/TypeAccelerator.Tests.ps1

Lines 210 to 211 in b664c2e

Accelerator = 'string'
Type = [System.String]

Contributes to #25952.

@xtqqczze xtqqczze changed the title Use string type accelerator Use [string] type accelerator Aug 25, 2025
@xtqqczze
xtqqczze force-pushed the ps-TypeAccelerators-string branch from df019e6 to 4395899 Compare August 25, 2025 12:14
@xtqqczze
xtqqczze marked this pull request as draft August 25, 2025 12:50
@xtqqczze
xtqqczze force-pushed the ps-TypeAccelerators-string branch from 4b0ab96 to ba7d95f Compare August 25, 2025 12:55
@xtqqczze
xtqqczze marked this pull request as ready for review August 25, 2025 13:03
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Sep 7, 2025
@xtqqczze
xtqqczze force-pushed the ps-TypeAccelerators-string branch from ba7d95f to 14c4097 Compare February 19, 2026 18:17
Copilot AI lite review requested due to automatic review settings August 28, 2026 21:39
@xtqqczze
xtqqczze force-pushed the ps-TypeAccelerators-string branch from 14c4097 to 58e5f6f Compare August 28, 2026 21:39
Copilot AI reviewed Aug 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@xtqqczze

xtqqczze commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

CodeFactor issue addressed by #27903.

@xtqqczze
xtqqczze requested a lite review from Copilot September 6, 2026 00:50
Copilot AI reviewed Sep 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are mechanical, consistent, and limited to type-name normalization without altering behavior.

Review details
  • Files reviewed: 48/48 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13 TravisEz13 is a code owner
@jshigetomi Justin Chung (jshigetomi) Awaiting requested review from jshigetomi jshigetomi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Review - Needed The PR is being reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze