Skip to content

Enable CA1852: Seal internal types #25890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xtqqczze wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable CA1852: Seal internal types #25890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,10 @@ dotnet_diagnostic.CA1846.severity = warning
# https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1847
dotnet_diagnostic.CA1847.severity = warning

# CA1852: Seal internal types
# https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852
dotnet_diagnostic.CA1852.severity = warning

# CA1853: Unnecessary call to 'Dictionary.ContainsKey(key)'
# https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1853
dotnet_diagnostic.CA1853.severity = warning
Expand Down
2 changes: 1 addition & 1 deletion test/tools/TestAlc/init/Init.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace Test.Isolated.Init
{
internal class CustomLoadContext : AssemblyLoadContext
internal sealed class CustomLoadContext : AssemblyLoadContext
{
private readonly string _dependencyDirPath;

Expand Down
2 changes: 1 addition & 1 deletion test/tools/TestExe/TestExe.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ internal enum EnvTarget
System = 2,
}

internal class TestExe
internal sealed class TestExe
{
private static int Main(string[] args)
{
Expand Down
Loading