Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Aug 22, 2025

Add sealed modifier to internal types without subtypes.

https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852

Fix #24094.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 22, 2025
@xtqqczze xtqqczze marked this pull request as draft August 22, 2025 13:28
@xtqqczze xtqqczze force-pushed the CA1852 branch 3 times, most recently from 25e6142 to ea67269 Compare August 25, 2025 09:50
@xtqqczze xtqqczze marked this pull request as ready for review August 25, 2025 09:50
@iSazonov
Copy link
Collaborator

/azp run PowerShell-CI-linux-packaging,PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@xtqqczze xtqqczze marked this pull request as draft August 26, 2025 12:03
@xtqqczze xtqqczze marked this pull request as ready for review August 26, 2025 12:07
@xtqqczze xtqqczze requested review from a team and jshigetomi as code owners August 26, 2025 12:07
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Sep 2, 2025
@microsoft-github-policy-service
Copy link
Contributor

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Review - Needed The PR is being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable CA1852: Seal internal types

2 participants