Repository navigation
Specify .NET Search by Build Type - #25837
Merged
Merged
Conversation
Aditya Patwardhan (adityapatwardhan)
approved these changes
Aug 7, 2025
Collaborator
Author
|
Updated version of #24992 |
….props for clarity and maintainability
Travis Plunk (TravisEz13)
approved these changes
Aug 20, 2025
Justin Chung (jshigetomi)
requested review from
Travis Plunk (TravisEz13) and
Aditya Patwardhan (adityapatwardhan)
August 20, 2025 21:11
Aditya Patwardhan (adityapatwardhan)
approved these changes
Aug 20, 2025
Collaborator
Author
|
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
📣 Hey @Justin Chung (@jshigetomi), how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
7 of 21 tasks
7 of 12 tasks
Travis Plunk (TravisEz13)
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 9, 2025
Co-authored-by: Travis Plunk (HE/HIM) <tplunk@ntdev.microsoft.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
2 of 5 tasks
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
Co-authored-by: Travis Plunk (HE/HIM) <tplunk@ntdev.microsoft.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
3 of 9 tasks
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
Co-authored-by: Travis Plunk (HE/HIM) <tplunk@ntdev.microsoft.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request updates the build configuration logic to better distinguish between different deployment types and set related properties more clearly. The main changes introduce an
AppDeploymentproperty that controls where the app host should be searched for, improving clarity and maintainability for framework-dependent, global tool, and self-contained deployments.Build configuration improvements:
AppDeploymentproperty inbuild.psm1to explicitly specify deployment type (GlobalTool,FxDependent, orSelfContained), replacing the previous approach of directly toggling properties based on runtime options.PowerShell.Common.propsto defineAppHostDotNetSearchbased on the newAppDeploymentproperty, ensuring the correct search locations are used for each deployment scenario.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header