Skip to content

Specify .NET Search by Build Type - #25837

Merged
Justin Chung (jshigetomi) merged 4 commits into
masterfrom
specifyDotnetSearch
Aug 21, 2025
Merged

Justin Chung (jshigetomi) merged 4 commits into
masterfrom
specifyDotnetSearch

Conversation

@jshigetomi

Copy link
Copy Markdown
Collaborator

PR Summary

This pull request updates the build configuration logic to better distinguish between different deployment types and set related properties more clearly. The main changes introduce an AppDeployment property that controls where the app host should be searched for, improving clarity and maintainability for framework-dependent, global tool, and self-contained deployments.

Build configuration improvements:

  • Added new AppDeployment property in build.psm1 to explicitly specify deployment type (GlobalTool, FxDependent, or SelfContained), replacing the previous approach of directly toggling properties based on runtime options.
  • Updated PowerShell.Common.props to define AppHostDotNetSearch based on the new AppDeployment property, ensuring the correct search locations are used for each deployment scenario.

PR Context

PR Checklist

@jshigetomi
Justin Chung (jshigetomi) requested a review from a team as a code owner August 7, 2025 17:51
@jshigetomi

Copy link
Copy Markdown
Collaborator Author

Updated version of #24992

@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Aug 18, 2025
Comment thread build.psm1 Resolved
Comment thread build.psm1 Resolved
Comment thread PowerShell.Common.props Resolved
Comment thread PowerShell.Common.props Resolved
@jshigetomi

Copy link
Copy Markdown
Collaborator Author

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@jshigetomi
Justin Chung (jshigetomi) merged commit 111a8e4 into master Aug 21, 2025
@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Aug 21, 2025 •

Copy link
Copy Markdown
Contributor

📣 Hey @Justin Chung (@jshigetomi), how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the specifyDotnetSearch branch August 21, 2025 17:20
Travis Plunk (TravisEz13) added a commit to TravisEz13/PowerShell that referenced this pull request Nov 9, 2025
Co-authored-by: Travis Plunk (HE/HIM) <tplunk@ntdev.microsoft.com>
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
Co-authored-by: Travis Plunk (HE/HIM) <tplunk@ntdev.microsoft.com>
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Co-authored-by: Travis Plunk (HE/HIM) <tplunk@ntdev.microsoft.com>
Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants